First version of auth handler library #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdean-digicatapult
requested review from
n3op2,
dblane-digicatapult and
syedhasandigi
dblane-digicatapult
approved these changes
May 13, 2024
n3op2
approved these changes
May 13, 2024
There was a problem hiding this comment.
Might be a good idea to get @dblane-digicatapult eyes on this as well. Just a comment on route names, do we really need to distinquish unauth and auth? can it be just /auth and then everything unauth? almost the end of the day I hope it makes sense
syedhasandigi
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: VR-78
implements a library on which we can build authenitcation either using cookies or bearer tokens with Keycloak as an IDP