This repository has been archived by the owner on Mar 14, 2024. It is now read-only.
VER-3: repo update. #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblane-digicatapult
suggested changes
Jun 8, 2023
.github/workflows/release.yml
Outdated
| - uses: actions/checkout@master | ||
| - uses: actions/setup-node@master | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.x |
.github/workflows/release.yml
Outdated
| - uses: actions/checkout@master | ||
| - uses: actions/setup-node@master | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.x |
.github/workflows/tests.yml
Outdated
| - uses: actions/checkout@master | ||
| - uses: actions/setup-node@master | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.x |
.github/workflows/tests.yml
Outdated
| - uses: actions/checkout@master | ||
| - uses: actions/setup-node@master | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: 16.x |
scripts/check-version.sh
Outdated
Comment on lines
10
to
20
| local HELM_CHART_VERSION=$(yq eval -o y '.version' ./helm/veritable-acapy-proxy/Chart.yaml) | ||
| local HELM_CHART_APP_VERSION=$(yq eval -o y '.appVersion' ./helm/veritable-acapy-proxy/Chart.yaml) | ||
|
|
||
| if [ "$PACKAGE_VERSION" != "$PACKAGE_LOCK_VERSION" ] || | ||
| [ "v$PACKAGE_VERSION" != "$HELM_VALUES_TAG_VERSION" ] || | ||
| [ "$PACKAGE_VERSION" != "$HELM_CHART_VERSION" ] || | ||
| [ "$PACKAGE_VERSION" != "$HELM_CHART_APP_VERSION" ]; then | ||
| echo "Inconsistent versions detected" | ||
| echo "PACKAGE_VERSION: $PACKAGE_VERSION" | ||
| echo "PACKAGE_LOCK_VERSION: $PACKAGE_LOCK_VERSION" | ||
| echo "HELM_VALUES_TAG_VERSION: $HELM_VALUES_TAG_VERSION" | ||
| echo "HELM_CHART_VERSION: $HELM_CHART_VERSION" | ||
| echo "HELM_CHART_APP_VERSION: $HELM_CHART_APP_VERSION" | ||
| exit 1 | ||
| [ "v$PACKAGE_VERSION" != "$HELM_VALUES_TAG_VERSION" ] || | ||
| [ "$PACKAGE_VERSION" != "$HELM_CHART_VERSION" ] || | ||
| [ "$PACKAGE_VERSION" != "$HELM_CHART_APP_VERSION" ]; then | ||
| echo "Inconsistent versions detected" | ||
| echo "PACKAGE_VERSION: $PACKAGE_VERSION" | ||
| echo "PACKAGE_LOCK_VERSION: $PACKAGE_LOCK_VERSION" | ||
| exit 1 |
There was a problem hiding this comment.
Remove all the helm references
Comment on lines
1
to
8
| apiVersion: v2 | ||
| name: veritable-acapy-proxy | ||
| appVersion: '1.1.0' | ||
| appVersion: '1.1.1' | ||
| description: A Helm chart for veritable-acapy-proxy | ||
| version: '1.1.0' | ||
| version: '1.1.1' | ||
| type: application | ||
| maintainers: | ||
| - name: digicatapult |
There was a problem hiding this comment.
Delete the helm folder
.github/workflows/tests.yml
Outdated
Comment on lines
70
to
78
| - name: Set up chart-testing | ||
| uses: helm/[email protected] | ||
| - name: Setup Minikube | ||
| uses: manusa/actions-setup-minikube@v2.3.0 | ||
| uses: manusa/actions-setup-minikube@v2.7.2 | ||
| with: | ||
| minikube version: 'v1.17.1' | ||
| kubernetes version: 'v1.19.2' | ||
| minikube version: 'v1.28.0' | ||
| kubernetes version: 'v1.25.4' | ||
| - name: Login to minikube docker registry | ||
| run: eval $(minikube -p minikube docker-env) | ||
| run: eval $(minikube -p minikube docker-env --unset) |
There was a problem hiding this comment.
Delete all the helm testing
.github/workflows/release.yml
Outdated
Comment on lines
76
to
87
| - name: Set up chart-testing | ||
| uses: helm/[email protected] | ||
| - name: Setup Minikube | ||
| uses: manusa/actions-setup-minikube@v2.3.0 | ||
| uses: manusa/actions-setup-minikube@v2.7.2 | ||
| with: | ||
| minikube version: 'v1.17.1' | ||
| kubernetes version: 'v1.19.2' | ||
| minikube version: 'v1.28.0' | ||
| kubernetes version: 'v1.25.4' | ||
| - name: Login to minikube docker registry | ||
| run: eval $(minikube -p minikube docker-env) | ||
| run: eval $(minikube -p minikube docker-env --unset) | ||
| - name: Build and Publish image | ||
| uses: docker/build-push-action@v2 | ||
| with: |
There was a problem hiding this comment.
Delete all the helm testing
dblane-digicatapult
suggested changes
Jun 12, 2023
Comment on lines
29
to
30
| echo "::set-output name=REPO_NAME::$REPO_NAME" | ||
| echo "::set-output name=ORG_NAME::$ORG_NAME" |
There was a problem hiding this comment.
Update to new output setting notation
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
mock-jwksdue to the need of ESM modules, please find error belowsub-wallet methods unauthenticated ✔ should fail with 401 Unauthorized listing all dids ✔ should list 1 did listing all dids without a wallet ✔ should error 401 listing dids with matching method ✔ should list 1 did listing dids with non-matching method ✔ should list 0 dids listing dids with invalid query ✔ should error 422 creating did ✔ should create a did creating did with invalid body ✔ should create a did wallet creation unauthenticated ✔ should fail with 401 Unauthorized as a new user ✔ should create a new wallet as a new user with invalid body ✔ should pass through error as an existing user ✔ should not create a new wallet api-docs ✔ should return 200 health ✔ health check server status unauthenticated ✔ should fail with 401 server status without a wallet ✔ should succeed and return server status transformApiDoc ✔ should transform input -> expectation (case 1) ✔ should transform input -> expectation (case 2) 18 passing (2s)