Replace black and pylint with ruff
#3333
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charludo
requested review from
PeterNerlich,
JoeyStk,
MizukiTemma,
jonbulz and
jarlhengstmengel
charludo
force-pushed
the
enhancement/replace-tools-with-ruff
branch
3 times, most recently
from
8a99cf6 to
89ef879
Compare
charludo
force-pushed
the
enhancement/replace-tools-with-ruff
branch
2 times, most recently
from
f914042 to
280f4a6
Compare
|
I've marked this as "ready for review". Due to the nature of the PR, this will constantly get merge conflicts, but luckily, 95% of the changes are "automatic" ones from ruff, so please feel free to review even if a merge conflict exists, I'll try to keep up with resolving them. |
cclauss
reviewed
Jan 15, 2025
charludo
force-pushed
the
enhancement/replace-tools-with-ruff
branch
from
280f4a6 to
c33177f
Compare
cclauss
reviewed
Jan 17, 2025
|
LGTM! |
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
Co-authored-by: Christian Clauss <[email protected]>
charludo
force-pushed
the
enhancement/replace-tools-with-ruff
branch
from
bc77cd4 to
20bd98f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description
I am SO sorry, dear reviewers 🙈
@cclauss do you have an opinion on this? 😄
Proposed changes
black->ruffpylint->ruffSide effects
Resolved issues
Fixes: #3234
Pull Request Review Guidelines