Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docker proposal branch] Using one-line commands #2

Open
wants to merge 2 commits into
base: docker_proposal
Choose a base branch
from
Open

[Docker proposal branch] Using one-line commands #2

wants to merge 2 commits into from

Conversation

racterub
Copy link

With current commit 3505579, Docker will trigger error "Empty continuation lines will become errors in a future release." and stop building.

code:

python-mode/Dockerfile

Lines 23 to 28 in 3505579

RUN set -ex \
&& cd /opt \
&& chmod +x build_vim.sh \
&& git clone https://github.com/vim/vim.git \
&& ./build_vim.sh ${PYTHON} \
&& rm -rf vim build_vim.sh

python-mode/Dockerfile

Lines 36 to 43 in 3505579

RUN set -ex \
&& cd ${PYTHON_MODE_HOME} \
&& find . -type f -name '*.pyc' -delete \
&& find . -type d -name '__pycache__' -delete \
&& ln -s ${PYTHON_MODE_HOME}tests/utils/test.py ${TEST_FILE} \
&& ln -s ${PYTHON_MODE_HOME}tests/utils/pymoderc ${PYMODE_RC} \
&& ln -s ${PYTHON_MODE_HOME}tests/utils/vimrc ${VIM_RC} \
&& touch /root/.vimrc.before /root/.vimrc.after \

With my commit, everything works fine.

diraol and others added 2 commits January 11, 2019 20:27
Now we can propperly test python-mode in an environment with a very well
defined python version and a vim built/compiled for this specific
version as well.

The best way is to use the `build_docker_images.sh` file in order to
create the docker image with all python versions you desire.

Also, in order to run the container you just have to do:

docker run --rm -it python-mode:<version>

Related to python-mode#977
@diraol
Copy link
Owner

diraol commented Jan 13, 2019

Hi @racterub Thanks for the PR!

Actually, the problem was just with line 43. There was an extra \ over there.

For maintenance purposes I think I prefer each command in a line (and it is ok, there is no warning with that!).

I've pushed the change. Can you try to see if the warning is still there?

Thanks!

@racterub
Copy link
Author

If you mean docker, it works fine 😄

@racterub
Copy link
Author

And, I'm thinking of putting a script on image for faster testing 😕
Which should look like this

root@847d2ab482e4:~# cat test.sh
#!/bin/bash

cd ~/.vim/pack/foo/start/python-mode
find . -type f -name '*.pyc' -delete && find . -type d -name '__pycache__' -delete
vim -i NONE -u debugvimrc.vim ~/test.py

@diraol
Copy link
Owner

diraol commented Jan 13, 2019

If you mean docker, it works fine

Great!

And, I'm thinking of putting a script on image for faster testing

Sure man! Go ahead! Any improvement is very welcome!

@diraol diraol force-pushed the docker_proposal branch 3 times, most recently from 636ff34 to e685f74 Compare May 12, 2019 01:06
@diraol diraol force-pushed the docker_proposal branch 3 times, most recently from 38ca89e to e7ccf5d Compare April 21, 2020 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants