DDST-416: Add fall-back logic for default image #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MorganDawe
reviewed
Aug 19, 2024
| @@ -131,8 +134,51 @@ public function addFieldValues(ItemInterface $item) { | |||
| if ($generated_url) { | |||
| $field->addValue($generated_url->getGeneratedUrl()); | |||
| } | |||
| else { | |||
| // Fallback to default image if URL generation fails. | |||
| $default_image_url = $this->getDefaultImageFromTaxonomy($entity, $image_style_name); | |||
There was a problem hiding this comment.
Given what is intended, i think the $image_style_name variable being passed in getDefaultImageFromTaxonomy should be $config['image_style']
There was a problem hiding this comment.
I pushed the updated code.
| foreach ($model_terms as $term) { | ||
| if ($term instanceof Term) { | ||
| // Load the media entity referenced by the field_defaultimage. | ||
| $media = $term->get('field_defaultimage')->entity; |
There was a problem hiding this comment.
The field is missing an underscore, should be field_default_image
There was a problem hiding this comment.
I pushed the updated code.
prashant-dgi
commented
Aug 21, 2024
| - In the Islandora Models vocabulary, select the appropriate default image for each term. | ||
|
|
||
| This setup allows the module to associate a default thumbnail (TN) with objects that lack a specific thumbnail for any given content type. | ||
|
|
There was a problem hiding this comment.
@MorganDawe updated the README file.
dynac01
approved these changes
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.