Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few edits #4

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

A few edits #4

wants to merge 10 commits into from

Conversation

Sepero
Copy link

@Sepero Sepero commented May 8, 2013

I deleted/added a bit of stuff. See how it looks. I cleaned it just a bit, I made the CSS files human readable. I clearly put IRC on the page with a link. Added an iframe for IRC chat in the page for easy access.

I wanted you to see that before I continue. I've got more planned- a FAQ, current status of the project, what to look forward to/what direction we are trying to go, possibly get a (NoSQL Django) logo, put a section listing how people can get involved in contributing, and more

@aburgel
Copy link
Member

aburgel commented May 8, 2013

Thanks for the patch. A few issues to take care of before I merge.

  1. The CSS files were minified for performance reasons, lets keep them that way.
  2. You forgot to commit django-nonrel.css
  3. I think the iframe IRC thing is overkill. I'm not sure if anyone goes to that channel anyways.

Since we only support mongo and appengine now (and that doesn't seem to change anytime soon), keeping their docs in separate boxes might be useful in the future. Like if we want to add FAQs, they will be separate for each backend.

@Sepero
Copy link
Author

Sepero commented May 8, 2013

  1. I was planning on separating out a lot of stuff from the css files since over 95% of it isn't used. That would seem to be the better way to improve performance.
  2. Good catch. My mistake in my .gitignore file.
  3. You're right that people won't go there if they can't get help there. I would like to see that people could get help on more than just the mailing list, but your presence is needed to make it happen. Let's either support irc or get rid of it.
  4. I have no problem with the separate boxes for GAE and MongoDB, but to say that we support MongoDB isn't completely the reality anymore. It was supported in 1.3, but that's quickly becoming retired. We'd both like to see future support for MongoDB, but for now, we have to accept that we need a lot more help.

@Sepero
Copy link
Author

Sepero commented May 8, 2013

Everything in dispute has been reverted back to previous form.

@wrwrwr
Copy link
Member

wrwrwr commented May 8, 2013

I find it convenient to work with Bootstrap's .less files rather than directly with any .css, if you're up for some more extensive styling you might also find this a more effective approach.

You could set up a lesscss compiler, checkout Bootstrap's sources, make a django-nonrel.less starting with a @import '/path/bootstrap.less' and only include one generated (minified) .css on the page. Another option could be the Bootstrap's Sass conversion (Sass is the more or less equivalent to less, seems this is the more popular workflow).

There's been a new Bootstrap release recently, so if you'd rather stick to the straightforward approach updating those .css files may be worth a moment.

Thanks for taking care of the site and sorry for the lengthy, and a bit off-topic, note :-)

@Sepero
Copy link
Author

Sepero commented May 8, 2013

Thanks for the input Wojtek. I lean towards the old fashioned way of doing things, but I'll definitely check out your suggestions :)

@Sepero
Copy link
Author

Sepero commented May 8, 2013

I updated the files from the bootstrap project.

@Sepero
Copy link
Author

Sepero commented May 12, 2013

Everything has been reverted. The only change in this pull request is update's from the Bootstrap project as suggested by Wojtek.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants