#164 - Introduce checkstyle #263
Conversation
- Added checkstyle profile using the rules from DKPro Core
|
@mawiesne @rzo1 Next step here would be to auto-format the code. I tend these days to have a script in my projects that copies an Eclipse formatter configuration into every one of the modules because that's the only sensible way I found to share these configurations in a module-specific way rather than forcing users to install a global style in their Eclipse. What IDEs are you using? |
|
IntelliJ IDEA (similar for Martin) |
- Add style config template and script to install it
|
Would it be working for you to configure IntelliJ as follows: https://build.ukp.informatik.tu-darmstadt.de/view/INCEpTION/job/INCEpTION%20main/de.tudarmstadt.ukp.inception.app$inception-app-webapp/doclinks/3/#_checkstyle_and_formatting |
- Change GH action to build up to the verify stage which includes checkstyle
|
@mawiesne do you also give a thumbs up for auto-formatting? This is a hammer action which would cause conflicts if you still have any pending changes lying around. |
|
Think we can import it ( we are doing it for OpenNLP in a similar way) |
|
Go for it, no changes open from my side. @reckart |
- Organize imports
- Auto-format dkpro-jwpl-api
- Auto-format dkpro-jwpl-datamachine
- Auto-format dkpro-jwpl-mwdumper
- Auto-format dkpro-jwpl-parser
- Auto-format dkpro-jwpl-revisionmachine
- Auto-format dkpro-jwpl-timemachine
- Auto-format dkpro-jwpl-tutorial
- Auto-format dkpro-jwpl-util
- Auto-format dkpro-jwpl-wikimachine
- Fix remaining checkstyle issues - Use try-with-resources in some places - Add re-generate hashcode/equals where only equals was implemented without hashcode
|
Ok, here is the big one :) |
What's in the PR
How to test manually
Automatic testing
Documentation