Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navy Linux Docker image support #11081

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

unixlabs
Copy link

@unixlabs unixlabs commented Oct 9, 2021

Request for the Navy Linux Docker image.

Checklist for Review

NOTE: This checklist is intended for the use of the Official Images maintainers both to track the status of your PR and to help inform you and others of where we're at. As such, please leave the "checking" of items to the repository maintainers. If there is a point below for which you would like to provide additional information or note completion, please do so by commenting on the PR. Thanks! (and thanks for staying patient with us ❤️)

@unixlabs
Copy link
Author

unixlabs commented Oct 9, 2021

Navy Linux Docker repo https://github.com/navy-linux/docker-images

@unixlabs
Copy link
Author

unixlabs commented Oct 9, 2021

can you please help on this error
Error: Unhandled error: HttpError: Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"}

@unixlabs unixlabs reopened this Oct 9, 2021
@unixlabs
Copy link
Author

unixlabs commented Oct 9, 2021

can you please help on this error Error: Unhandled error: HttpError: Validation Failed: {"resource":"IssueComment","code":"unprocessable","field":"data","message":"Body is too long (maximum is 65536 characters)"}

fixed.

@tianon
Copy link
Member

tianon commented Oct 11, 2021

I'm sorry -- the diff is an expected failure because this is a new base image and thus will inevitably have a longer file listing than the CI can reasonably place into a comment.

@unixlabs unixlabs closed this Oct 11, 2021
@unixlabs unixlabs reopened this Oct 11, 2021
@unixlabs
Copy link
Author

test pass on base image
sudo ./run.sh navylinux/minimal
testing navylinux/minimal
'utc' [1/3]...failed; unexpected output:
--- /home/admin/docker/official-images/test/tests/utc/expected-std-out.txt 2021-10-11 23:02:24.626575423 +0500
+++ - 2021-10-12 04:17:57.849964330 +0500
@@ -1 +1 @@
-UTC
+PDT
'no-hard-coded-passwords' [2/3]...passed
'override-cmd' [3/3]...passed

@unixlabs
Copy link
Author

@tianon can please try again to run the job.

@tianon
Copy link
Member

tianon commented Mar 25, 2022

Sorry for the delay 🙇

I'll try to explain this more clearly -- what I expect to see for a base image like this is a repository with a branch on it (can be the main branch if you want, more on that in a second) that has a Dockerfile that isn't much more than FROM scratch + ADD xyz-foo-bar.tar.gz / + CMD ["bash"] side-by-side with the committed tarball. The primary challenge is that the tarball needs to not be modified by any commits in the history, so what I usually do is have source code (sometimes the Dockerfile too) on a main or master branch, and then have a separate dist branch that is only ever one commit above my main branch which adds the necessary tarball (with a force push that includes the new tarball in the same single commit for every image update). For supporting multiple architectures, I usually rename that dist branch after the architecture, such as dist-amd64.

If there's anything I can do to help set that up, please let me know!

@github-actions
Copy link

github-actions bot commented Apr 2, 2022

Diff for b088ef3:
diff --git a/_bashbrew-cat b/_bashbrew-cat
index bdfae4a..0e6ce60 100644
--- a/_bashbrew-cat
+++ b/_bashbrew-cat
@@ -1 +1,5 @@
-Maintainers: New Image! :D (@docker-library-bot)
+Maintainers: Navy Linux by Navy Foundation <[email protected]> (@navylinux)
+GitRepo: https://github.com/navy-linux/docker-images.git
+
+Tags: 8.4r1, latest
+GitCommit: 664aec2a49d0323c61b6ff183fcb35ed943ae182
diff --git a/_bashbrew-list b/_bashbrew-list
index e69de29..56543e9 100644
--- a/_bashbrew-list
+++ b/_bashbrew-list
@@ -0,0 +1,2 @@
+navylinux:8.4r1
+navylinux:latest
diff --git a/navylinux_latest/Dockerfile b/navylinux_latest/Dockerfile
new file mode 100644
index 0000000..5e6097d
--- /dev/null
+++ b/navylinux_latest/Dockerfile
@@ -0,0 +1,5 @@
+FROM scratch
+ADD amd64/navylinux-8-amd64.img /
+LABEL org.label-schema.schema-version="1.0"     org.label-schema.name="Navy Linux"     org.label-schema.vendor="NavyLinux"     org.label-schema.license="GPLv2"     org.label-schema.build-date="20210723"
+RUN yum update -y
+CMD ["/bin/bash"]
diff --git a/navylinux_latest/amd64/navylinux-8-amd64.img b/navylinux_latest/amd64/navylinux-8-amd64.img
new file mode 100644
index 0000000..d73246c
Binary files /dev/null and b/navylinux_latest/amd64/navylinux-8-amd64.img differ

@unixlabs
Copy link
Author

unixlabs commented Apr 2, 2022

Sorry for the delay bow

I'll try to explain this more clearly -- what I expect to see for a base image like this is a repository with a branch on it (can be the main branch if you want, more on that in a second) that has a Dockerfile that isn't much more than FROM scratch + ADD xyz-foo-bar.tar.gz / + CMD ["bash"] side-by-side with the committed tarball. The primary challenge is that the tarball needs to not be modified by any commits in the history, so what I usually do is have source code (sometimes the Dockerfile too) on a main or master branch, and then have a separate dist branch that is only ever one commit above my main branch which adds the necessary tarball (with a force push that includes the new tarball in the same single commit for every image update). For supporting multiple architectures, I usually rename that dist branch after the architecture, such as dist-amd64.

If there's anything I can do to help set that up, please let me know!

@tianon Please review the updated pull request. and Thanks for the help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants