add annotations input #992

crazy-max · 2023-10-24T05:27:17Z

follow-up docker/buildx#2020
fixes #958

favonia · 2023-10-25T14:05:09Z

Close #958. (Will my keyword works?)

EDIT: it doesn't seem to work... but anyway that might be the issue that should be closed along with this PR.

favonia · 2023-10-25T20:24:14Z

src/context.ts

+    await Util.asyncForEach(inputs.annotations, async annotation => {
+      args.push('--annotation', annotation);
+    });
+  }


I'm glad that there's a version checking. Could we give an error in an else branch, saying it's not supported?

Signed-off-by: CrazyMax <[email protected]>

tonistiigi · 2023-11-13T20:52:06Z

README.md

@@ -217,6 +217,7 @@ Following inputs can be used as `step.with` keys
 |--------------------|-------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
 | `add-hosts`        | List/CSV    | List of [customs host-to-IP mapping](https://docs.docker.com/engine/reference/commandline/build/#add-entries-to-container-hosts-file---add-host) (e.g., `docker:10.180.0.1`)      |
 | `allow`            | List/CSV    | List of [extra privileged entitlement](https://docs.docker.com/engine/reference/commandline/buildx_build/#allow) (e.g., `network.host,security.insecure`)                         |
+| `annotations`      | List        | List of annotation to set to the image                                                                                                                                            |


Could we get some more examples of what is the expected format?

@dvdksn Like other examples we have in https://docs.docker.com/build/ci/github-actions/ it might good to have one for annotations as suggested by @tonistiigi. Same in https://github.com/docker/buildx/blob/master/docs/reference/buildx_build.md for --annotation flag. Let me know if you need help about the syntax.

👍🏻 sgtm, we only have it mentioned in the exporter docs currently I think

https://docs.docker.com/build/exporters/image-registry/#annotations
https://docs.docker.com/build/exporters/oci-docker/#annotations

favonia · 2023-11-15T23:41:09Z

@crazy-max @tonistiigi Hi, as an outsider I feel the PR might not be ready for merging. It seems to have two outstanding issues: (1) the CI was testing "v0.12.0-rc1" not the latest version, which doesn't seem to be normal, and (2) it will silently ignore annotations when buildx is too old. Of course, we can fix these in another PR, but I found the merge a bit strange given these issues. I'll be happy to learn that I'm wrong. Anyway, thank you for moving forward on this issue quickly. 😀

crazy-max · 2023-11-16T09:51:45Z

(1) the CI was testing "v0.12.0-rc1" not the latest version,

Yes we are going to open a follow-up here to update to latest when Buildx 0.12.0 is GA this week. We have done this quite often when adding new inputs like build-contexts for 0.8.0.

[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://togithub.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://togithub.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://togithub.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/build-push-action/pull/992](https://togithub.com/docker/build-push-action/pull/992) - Add `secret-envs` input by [@elias-lundgren](https://togithub.com/elias-lundgren) in [https://github.com/docker/build-push-action/pull/980](https://togithub.com/docker/build-push-action/pull/980) - Bump [@babel/traverse](https://togithub.com/babel/traverse) from 7.17.3 to 7.23.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/docker/build-push-action/pull/991](https://togithub.com/docker/build-push-action/pull/991) - Bump [@docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [https://github.com/docker/build-push-action/pull/990](https://togithub.com/docker/build-push-action/pull/990) [https://github.com/docker/build-push-action/pull/1006](https://togithub.com/docker/build-push-action/pull/1006) **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/matter-labs/zksync-withdrawal-finalizer).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate logo banner](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://togithub.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://togithub.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://togithub.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/build-push-action/pull/992](https://togithub.com/docker/build-push-action/pull/992) - Add `secret-envs` input by [@elias-lundgren](https://togithub.com/elias-lundgren) in [https://github.com/docker/build-push-action/pull/980](https://togithub.com/docker/build-push-action/pull/980) - Bump [@babel/traverse](https://togithub.com/babel/traverse) from 7.17.3 to 7.23.2 by [@dependabot](https://togithub.com/dependabot) in [https://github.com/docker/build-push-action/pull/991](https://togithub.com/docker/build-push-action/pull/991) - Bump [@docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [https://github.com/docker/build-push-action/pull/990](https://togithub.com/docker/build-push-action/pull/990) [https://github.com/docker/build-push-action/pull/1006](https://togithub.com/docker/build-push-action/pull/1006) **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Mogyuchi/gh-test).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [docker/build-push-action](https://togithub.com/docker/build-push-action) | action | minor | `v5.0.0` -> `v5.1.0` | --- ### Release Notes <details> <summary>docker/build-push-action (docker/build-push-action)</summary> ### [`v5.1.0`](https://togithub.com/docker/build-push-action/releases/tag/v5.1.0) [Compare Source](https://togithub.com/docker/build-push-action/compare/v5.0.0...v5.1.0) - Add `annotations` input by [@crazy-max](https://togithub.com/crazy-max) in [https://github.com/docker/build-push-action/pull/992](https://togithub.com/docker/build-push-action/pull/992) - Add `secret-envs` input by [@elias-lundgren](https://togithub.com/elias-lundgren) in [https://github.com/docker/build-push-action/pull/980](https://togithub.com/docker/build-push-action/pull/980) - Bump [@babel/traverse](https://togithub.com/babel/traverse) from 7.17.3 to 7.23.2 in [https://github.com/docker/build-push-action/pull/991](https://togithub.com/docker/build-push-action/pull/991) - Bump [@docker/actions-toolkit](https://togithub.com/docker/actions-toolkit) from 0.13.0-rc.1 to 0.14.0 in [https://github.com/docker/build-push-action/pull/990](https://togithub.com/docker/build-push-action/pull/990) [https://github.com/docker/build-push-action/pull/1006](https://togithub.com/docker/build-push-action/pull/1006) **Full Changelog**: docker/build-push-action@v5.0.0...v5.1.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Rapporteket/docker).  Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>

Bumps [docker/build-push-action](https://github.com/docker/build-push- action) from 5 to 6. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/docker/build-push- action/releases">docker/build-push-action's releases</a>.</em></p> <blockquote> <h2>v6.0.0</h2> <ul> <li>Export build record and generate <a href="https://docs.docker.com/build/ci/github-actions/build- summary/">build summary</a> by <a href="https://github.com/crazy- max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push- action/pull/1120">docker/build-push-action#1120</a></li> <li>Bump <code>@docker/actions-toolkit</code> from 0.24.0 to 0.26.0 in <a href="https://redirect.github.com/docker/build-push- action/pull/1132">docker/build-push-action#1132</a> <a href="https://redirect.github.com/docker/build-push- action/pull/1136">docker/build-push-action#1136</a> <a href="https://redirect.github.com/docker/build-push- action/pull/1138">docker/build-push-action#1138</a></li> <li>Bump braces from 3.0.2 to 3.0.3 in <a href="https://redirect.github.com/docker/build-push- action/pull/1137">docker/build-push-action#1137</a></li> </ul> <blockquote> <p>[!NOTE] This major release adds support for generating <a href="https://docs.docker.com/build/ci/github-actions/build- summary/">Build summary</a> and exporting build record for your build. You can disable this feature by setting <a href="https://docs.docker.com/build/ci/github-actions/build- summary/#disable-job-summary"> <code>DOCKER_BUILD_NO_SUMMARY: true</code> environment variable in your workflow</a>.</p> </blockquote> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push- action/compare/v5.4.0...v6.0.0">https://github.com/docker/build-push- action/compare/v5.4.0...v6.0.0</a></p> <h2>v5.4.0</h2> <ul> <li>Show builder information before building by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push- action/pull/1128">docker/build-push-action#1128</a></li> <li>Handle attestations correctly with provenance and sbom inputs by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push- action/pull/1086">docker/build-push-action#1086</a></li> <li>Bump <code>@docker/actions-toolkit</code> from 0.19.0 to 0.24.0 in <a href="https://redirect.github.com/docker/build-push- action/pull/1088">docker/build-push-action#1088</a> <a href="https://redirect.github.com/docker/build-push- action/pull/1105">docker/build-push-action#1105</a> <a href="https://redirect.github.com/docker/build-push- action/pull/1121">docker/build-push-action#1121</a> <a href="https://redirect.github.com/docker/build-push- action/pull/1127">docker/build-push-action#1127</a></li> <li>Bump undici from 5.28.3 to 5.28.4 in <a href="https://redirect.github.com/docker/build-push- action/pull/1090">docker/build-push-action#1090</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push- action/compare/v5.3.0...v5.4.0">https://github.com/docker/build-push- action/compare/v5.3.0...v5.4.0</a></p> <h2>v5.3.0</h2> <ul> <li>Bump <code>@docker/actions-toolkit</code> from 0.18.0 to 0.19.0 in <a href="https://redirect.github.com/docker/build-push- action/pull/1080">docker/build-push-action#1080</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push- action/compare/v5.2.0...v5.3.0">https://github.com/docker/build-push- action/compare/v5.2.0...v5.3.0</a></p> <h2>v5.2.0</h2> <ul> <li>Disable quotes detection for <code>outputs</code> input by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push- action/pull/1074">docker/build-push-action#1074</a></li> <li>Warn about ignored inputs by <a href="https://github.com/favonia"><code>@favonia</code></a> in <a href="https://redirect.github.com/docker/build-push- action/pull/1019">docker/build-push-action#1019</a></li> <li>Bump <code>@docker/actions-toolkit</code> from 0.14.0 to 0.18.0 in <a href="https://redirect.github.com/docker/build-push- action/pull/1070">docker/build-push-action#1070</a></li> <li>Bump undici from 5.26.3 to 5.28.3 in <a href="https://redirect.github.com/docker/build-push- action/pull/1057">docker/build-push-action#1057</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push- action/compare/v5.1.0...v5.2.0">https://github.com/docker/build-push- action/compare/v5.1.0...v5.2.0</a></p> <h2>v5.1.0</h2> <ul> <li>Add <code>annotations</code> input by <a href="https://github.com/crazy-max"><code>@crazy-max</code></a> in <a href="https://redirect.github.com/docker/build-push- action/pull/992">docker/build-push-action#992</a></li> <li>Add <code>secret-envs</code> input by <a href="https://github.com/elias-lundgren"><code>@elias- lundgren</code></a> in <a href="https://redirect.github.com/docker/build-push- action/pull/980">docker/build-push-action#980</a></li> <li>Bump <code>@babel/traverse</code> from 7.17.3 to 7.23.2 in <a href="https://redirect.github.com/docker/build-push- action/pull/991">docker/build-push-action#991</a></li> <li>Bump <code>@docker/actions-toolkit</code> from 0.13.0-rc.1 to 0.14.0 in <a href="https://redirect.github.com/docker/build-push- action/pull/990">docker/build-push-action#990</a> <a href="https://redirect.github.com/docker/build-push- action/pull/1006">docker/build-push-action#1006</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/docker/build-push- action/compare/v5.0.0...v5.1.0">https://github.com/docker/build-push- action/compare/v5.0.0...v5.1.0</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="docker/build-push-action@31159d49 c0d4756269a0940a750801a1ea5d7003"><code>31159d4</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push- action/issues/1149">sagemath#1149</a> from docker/dependabot/npm_and_yarn/docker/actions-t...</li> <li><a href="docker/build-push-action@07e1c3e1 48c1973f78a15cef24eae4371e57280d"><code>07e1c3e</code></a> chore: update generated content</li> <li><a href="docker/build-push-action@f7febd62 1d13a78cf2751da16b38233f0e819581"><code>f7febd6</code></a> chore(deps): Bump <code>@docker/actions-toolkit</code> from 0.26.2 to 0.27.0</li> <li><a href="docker/build-push-action@f6010ea7 0151369b06f0194be1051fbbdff851b2"><code>f6010ea</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push- action/issues/1147">sagemath#1147</a> from docker/dependabot/npm_and_yarn/docker/actions-t...</li> <li><a href="docker/build-push-action@c0a6b968 0fb13e0dc73747f7da2bb27d9f5a3beb"><code>c0a6b96</code></a> chore: update generated content</li> <li><a href="docker/build-push-action@0dfe9c3d 416a6cc790f37ce7704bbab23e3442db"><code>0dfe9c3</code></a> chore(deps): Bump <code>@docker/actions-toolkit</code> from 0.26.1 to 0.26.2</li> <li><a href="docker/build-push-action@94f8f8c2 eec4bc3f1d78c1755580779804cb87b2"><code>94f8f8c</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push- action/issues/1142">sagemath#1142</a> from docker/dependabot/npm_and_yarn/docker/actions-t...</li> <li><a href="docker/build-push-action@22f4433c 588020040c09698d8998964f307cd95b"><code>22f4433</code></a> chore: update generated content</li> <li><a href="docker/build-push-action@6721c560 15505c8bc8e7087fae9263d32715d7a3"><code>6721c56</code></a> chore(deps): Bump <code>@docker/actions-toolkit</code> from 0.26.0 to 0.26.1</li> <li><a href="docker/build-push-action@4367da97 8b557b70738a51fed31c93e6a240dfb3"><code>4367da9</code></a> Merge pull request <a href="https://redirect.github.com/docker/build-push- action/issues/1140">sagemath#1140</a> from docker/dependabot/github_actions/docker/bake-ac...</li> <li>Additional commits viewable in <a href="https://github.com/docker/build-push- action/compare/v5...v6">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot- badges.githubapp.com/badges/compatibility_score?dependency- name=docker/build-push-action&package-manager=github_actions&previous- version=5&new-version=6)](https://docs.github.com/en/github/managing- security-vulnerabilities/about-dependabot-security-updates#about- compatibility-scores) You can trigger a rebase of this PR by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> > **Note** > Automatic rebases have been disabled on this pull request as it has been open for over 30 days. URL: sagemath#38267 Reported by: dependabot[bot] Reviewer(s): Kwankyu Lee

chore(deps): Bump docker/build-push-action from 5 to 6 Bumps docker/build-push-action from 5 to 6. Release notes Sourced from docker/build-push-action's releases. v6.0.0 Export build record and generate build summary by @crazy-max in docker/build-push-action#1120 Bump @docker/actions-toolkit from 0.24.0 to 0.26.0 in docker/build-push-action#1132 docker/build-push-action#1136 docker/build-push-action#1138 Bump braces from 3.0.2 to 3.0.3 in docker/build-push-action#1137 [!NOTE] This major release adds support for generating Build summary and exporting build record for your build. You can disable this feature by setting DOCKER_BUILD_NO_SUMMARY: true environment variable in your workflow. Full Changelog: docker/[email protected] v5.4.0 Show builder information before building by @crazy-max in docker/build-push-action#1128 Handle attestations correctly with provenance and sbom inputs by @crazy-max in docker/build-push-action#1086 Bump @docker/actions-toolkit from 0.19.0 to 0.24.0 in docker/build-push-action#1088 docker/build-push-action#1105 docker/build-push-action#1121 docker/build-push-action#1127 Bump undici from 5.28.3 to 5.28.4 in docker/build-push-action#1090 Full Changelog: docker/[email protected] v5.3.0 Bump @docker/actions-toolkit from 0.18.0 to 0.19.0 in docker/build-push-action#1080 Full Changelog: docker/[email protected] v5.2.0 Disable quotes detection for outputs input by @crazy-max in docker/build-push-action#1074 Warn about ignored inputs by @favonia in docker/build-push-action#1019 Bump @docker/actions-toolkit from 0.14.0 to 0.18.0 in docker/build-push-action#1070 Bump undici from 5.26.3 to 5.28.3 in docker/build-push-action#1057 Full Changelog: docker/[email protected] v5.1.0 Add annotations input by @crazy-max in docker/build-push-action#992 Add secret-envs input by @elias-lundgren in docker/build-push-action#980 Bump @babel/traverse from 7.17.3 to 7.23.2 in docker/build-push-action#991 Bump @docker/actions-toolkit from 0.13.0-rc.1 to 0.14.0 in docker/build-push-action#990 docker/build-push-action#1006 Full Changelog: docker/[email protected] Commits 4f58ea7 Merge pull request #1234 from docker/dependabot/npm_and_yarn/docker/actions-t... 49b5ea6 chore: update generated content 13c9fdd chore(deps): Bump @docker/actions-toolkit from 0.38.0 to 0.39.0 e44afff Merge pull request #1232 from docker/dependabot/npm_and_yarn/path-to-regexp-6... 67ebad3 chore(deps): Bump path-to-regexp from 6.2.2 to 6.3.0 32945a3 Merge pull request #1230 from docker/dependabot/npm_and_yarn/docker/actions-t... e0fe9cf chore: update generated content 8f1ff6b chore(deps): Bump @docker/actions-toolkit from 0.37.1 to 0.38.0 5cd11c3 Merge pull request #1211 from crazy-max/summary-info-message 0aba704 chore: update generated content Additional commits viewable in compare view Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase. Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: @dependabot rebase will rebase this PR @dependabot recreate will recreate this PR, overwriting any edits that have been made to it @dependabot merge will merge this PR after your CI passes on it @dependabot squash and merge will squash and merge this PR after your CI passes on it @dependabot cancel merge will cancel a previously requested merge and block automerging @dependabot reopen will reopen this PR if it is closed @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) Reviewed-by: Vladimir Vshivkov

crazy-max force-pushed the annotations branch from f0280bd to a0bf22b Compare October 24, 2023 09:33

crazy-max requested review from tonistiigi and jsternberg October 24, 2023 09:39

crazy-max marked this pull request as ready for review October 24, 2023 09:39

crazy-max mentioned this pull request Oct 25, 2023

Feature request and discussion: support of annotations docker/metadata-action#332

Closed

crazy-max mentioned this pull request Oct 25, 2023

labelPrefix flavor for annotations support docker/metadata-action#351

Closed

crazy-max force-pushed the annotations branch from a0bf22b to 662cd77 Compare October 25, 2023 15:11

favonia reviewed Oct 25, 2023

View reviewed changes

crazy-max mentioned this pull request Oct 26, 2023

build: make annotations work with push flag docker/buildx#2098

Merged

crazy-max added 3 commits October 27, 2023 06:42

ci: bump buildx to v0.12.0-rc1

b425c4c

Signed-off-by: CrazyMax <[email protected]>

add annotations input

248131c

Signed-off-by: CrazyMax <[email protected]>

chore: update generated content

c66ae3a

Signed-off-by: CrazyMax <[email protected]>

crazy-max force-pushed the annotations branch from 7e8a65e to c66ae3a Compare October 27, 2023 04:43

This was referenced Nov 10, 2023

chore: add annotations to manifest philips-software/amp-devcontainer#201

Merged

Simplify adding annotations to the manifest philips-software/amp-devcontainer#202

Closed

tonistiigi reviewed Nov 13, 2023

View reviewed changes

crazy-max added the needs/docs-follow-up label Nov 14, 2023

tonistiigi approved these changes Nov 15, 2023

View reviewed changes

tonistiigi merged commit 7a786bb into docker:master Nov 15, 2023
52 checks passed

crazy-max deleted the annotations branch November 16, 2023 09:51

dvdksn mentioned this pull request Nov 17, 2023

Annotations documentation docker/docs#18709

Closed

jcgillespie mentioned this pull request Jun 17, 2024

Bump docker/build-push-action from 5 to 6 jcgillespie/mssql-sqlpackage-docker#41

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add annotations input #992

add annotations input #992

crazy-max commented Oct 24, 2023 •

edited

Loading

favonia commented Oct 25, 2023 •

edited

Loading

favonia Oct 25, 2023 •

edited

Loading

tonistiigi Nov 13, 2023

crazy-max Nov 14, 2023

dvdksn Nov 14, 2023 •

edited

Loading

favonia commented Nov 15, 2023 •

edited

Loading

crazy-max commented Nov 16, 2023

add annotations input #992

add annotations input #992

Conversation

crazy-max commented Oct 24, 2023 • edited Loading

favonia commented Oct 25, 2023 • edited Loading

favonia Oct 25, 2023 • edited Loading

Choose a reason for hiding this comment

tonistiigi Nov 13, 2023

Choose a reason for hiding this comment

crazy-max Nov 14, 2023

Choose a reason for hiding this comment

dvdksn Nov 14, 2023 • edited Loading

Choose a reason for hiding this comment

favonia commented Nov 15, 2023 • edited Loading

crazy-max commented Nov 16, 2023

crazy-max commented Oct 24, 2023 •

edited

Loading

favonia commented Oct 25, 2023 •

edited

Loading

favonia Oct 25, 2023 •

edited

Loading

dvdksn Nov 14, 2023 •

edited

Loading

favonia commented Nov 15, 2023 •

edited

Loading