vendor: github.com/docker/docker 69687190936d (master, v28.0-dev)

[thaJeztah]

• depends on / stacked on vendor: github.com/docker/docker 6f6c3b921180 (master, v28.0.0-dev) #5716
• testing changes from pkg/system: deprecate MkdirAll and remove custom volume GUID handling moby/moby#49162
• testing changes from Remove use of pkg/pools in archive moby/moby#49117
• testing changes from Split idtools to an internal package and package to be moved moby/moby#49087

vendor: github.com/docker/docker 69687190936d (master, v28.0-dev)

full diff: moby/moby@50212d2...6968719

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.51%. Comparing base (4e217ae) to head (0df5530).

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5708      +/-   ##
==========================================
+ Coverage   59.48%   59.51%   +0.03%     
==========================================
  Files         343      346       +3     
  Lines       29369    29376       +7     
==========================================
+ Hits        17469    17483      +14     
+ Misses      10928    10923       -5     
+ Partials      972      970       -2     

[thaJeztah]

After this, pkg/pools is still in use in the CLI for the Classic Builder;

cli/cli/command/image/build/context.go

Lines 426 to 447 in 3b49deb

	// Compress the build context for sending to the API
	func Compress(buildCtx io.ReadCloser) (io.ReadCloser, error) {
	pipeReader, pipeWriter := io.Pipe()
	go func() {
	compressWriter, err := archive.CompressStream(pipeWriter, archive.Gzip)
	if err != nil {
	pipeWriter.CloseWithError(err)
	}
	defer buildCtx.Close()
	if _, err := pools.Copy(compressWriter, buildCtx); err != nil {
	pipeWriter.CloseWithError(errors.Wrap(err, "failed to compress context"))
	compressWriter.Close()
	return
	}
	compressWriter.Close()
	pipeWriter.Close()
	}()
	return pipeReader, nil
	}

That was;

• added in Build stdin with compress #233
• to fix '--compress', '-f -' and context do not play along #212

However, on that PR, it was suggested to move the build.Compress function to pkg/archive in moby; #233 (comment) - looks like that never happend.

[thaJeztah]

Failures look legit / related;

time="2024-12-25T10:56:00Z" level=error msg="Can't add file /var/folders/95/0ydz4d79163427j3k5crp3fh0000gn/T/cp-test-465366053/file1 to tar: open /var/folders/95/0ydz4d79163427j3k5crp3fh0000gn/T/cp-test-465366053/file1: no such file or directory"
time="2024-12-25T10:56:00Z" level=error msg="Can't close tar writer: archive/tar: missed writing 8 bytes"
--- FAIL: TestRunCopyFromContainerToFilesystem (0.01s)
    cp_test.go:85: assertion failed: error is not nil: unexpected EOF
Error: something went wrong
Error: exit status 33
Error: exit status 130
time="2024-12-25T10:56:01Z" level=error msg="Error waiting for container: removal failed"
time="2024-12-25T10:56:01Z" level=error msg="error waiting for container: no such container: non-existent-container-id"
FAIL

[thaJeztah]

Rebased after #5715 was merged, which should fix the faulty test.