Only override service mac if set on the main network. #12439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apollo13
force-pushed
the
fb-container-mac
branch
from
897531f to
5d5a736
Compare
apollo13
force-pushed
the
fb-container-mac
branch
from
5d5a736 to
7ea49aa
Compare
ndeloof
approved these changes
Jan 7, 2025
Signed-off-by: Florian Apolloner <[email protected]>
apollo13
force-pushed
the
fb-container-mac
branch
from
7ea49aa to
97e8a07
Compare
|
Thank you for the quasi instant turnaround @ndeloof. Much appreciated. I guess asking for a new point release is a bit much given there was one an hour ago? 😀 Do you have a rough idea when you want to do the next release? I am asking because then I'd know whether I will just put my podman PRs on hold for now or look for a workaround in the meantime. No pressure though, if you can give me an educated guess that would be more than helpful!
…On Tue, Jan 7, 2025, at 16:16, Nicolas De loof wrote:
Merged #12439 <#12439> into main.
—
Reply to this email directly, view it on GitHub
<#12439 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAT5C7TU5AUVAMKRBE2M4T2JPVWNAVCNFSM6AAAAABUXJ3UXGVHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJVHA2DAMZUGEZDSNI>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
I am using compose against podman which exposes API 1.41 and as such does not yet support mac per network. But the existing code unconditionally overrides the mac address set on the service level with the mac from the main network even if none is defined -- hence only override if it is actually set.
Related issue
(not mandatory) A picture of a cute animal, if possible in relation to what you did