InputCommon/DolphinQt: Fix sometimes broken syntax highlighting in IOWindow. #13280
+88
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jordan-woyak
force-pushed
the
input-expressions-highlighting
branch
2 times, most recently
from
7f58ecb to
e3b0ce9
Compare
jordan-woyak
changed the title
jordan-woyak
force-pushed
the
input-expressions-highlighting
branch
from
e3b0ce9 to
e91b83d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QSyntaxHighlighteris a neat idea, allowing just altered "blocks" to be reformatted, but making this work properly requires the parser state be stored for each text block as a single int value, and rigging that up would just be a huge hassle.Prior to this change only the altered block was re-formatted, hoping other blocks wouldn't need re-formatting, which really isn't a safe assumption.
It seems our expressions are often a single block or are edited left-to-right so a highlighting failure wasn't often seen but incorrect highlighting could be coerced by temporarily deleting delimiters mid-string and whatnot.
This change stops the use of
QSyntaxHighlighterand just re-parses and re-formats the entire document on change.Unicode characters are also now properly handled.