WIP/Tests | Widen test code coverage

[edwardneal]

WIP - running this through CI and Codecov to make sure my local coverage figures align.

This PR ensures that the public API surface for SqlDataRecord and SqlMetaData are covered by tests. It also expands coverage of some of the basic data validation on SqlParameter and SqlCommand.

[ErikEJ]

@edwardneal Did you look at the code coverage report for "inspiration" ?

[edwardneal]

I did; Codecov aligns with it:

• SqlDataRecord.cs
• SqlDataRecord.netcore.cs
• SqlDataRecord.netfx.cs
• SqlMetaData.cs

The code coverage for SqlDataRecord is currently ~75%, where I expect this PR will bring it to close to 100% in the code coverage report. The code paths which aren't covered are ones which can't ever be called and are due to be removed; once that happens I expect these two files will hit 100%.

SqlParameter is a much larger class, and it's got a custom TypeConverter which doesn't appear to have test coverage. I've added a few tests for basic validation, but the class will need more work here.

[edwardneal]

@mdaigle would you mind triggering the Azure Pipelines bot please? It looks like CI has stopped triggering on my PRs.

[mdaigle]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[edwardneal]

Thanks. It looks like there's a slightly deeper problem with CI - the Password and the Azure_Password variables (and maybe other secret variables?) aren't being substituted.

[mdaigle]

Thanks. It looks like there's a slightly deeper problem with CI - the Password and the Azure_Password variables (and maybe other secret variables?) aren't being substituted.

Yeah, I need to dig into this further. We had a security action item to limit forked build access to pipeline secrets and I think the trigger was pulled on that before we made accommodating changes. There's a general trend toward locked down permissions for forked builds. We need to start updating tests to use dynamically generated (rather than static) resources so that we don't rely on pipeline secrets.

@David-Engel started doing some work in this direction with #2750. I bumped the pipeline there to see if mac tests are passing with those changes.