[XABT] Create separate compress assemblies task. #9637
Draft
+162
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpobst
force-pushed
the
separate-compress
branch
from
0e05e6a to
1ce7fb1
Compare
dellis1972
reviewed
Jan 6, 2025
| { | ||
| var value = item.GetMetadata (name); | ||
|
|
||
| if (string.IsNullOrWhiteSpace (value)) | ||
| return defaultValue; | ||
|
|
||
| return value; | ||
| return (T?)Convert.ChangeType (value, typeof (T)); |
There was a problem hiding this comment.
This throws https://learn.microsoft.com/en-us/dotnet/api/system.convert.changetype?view=net-9.0. We should handle that case? and return the default.
There was a problem hiding this comment.
I think this only throws if the input cannot be converted to the requested type, like say you passed in "tru" and T is bool.
Passing in an invalid input is a bug that should be fixed, and it feels like we should indeed throw an exception here rather than silently swallow the error and return the default.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.