Skip to content

Use maintained tcort Markdown link-check action - #10634

Merged
danroth27 merged 2 commits into
mainfrom
maintenance/tcort-markdown-link-check
Oct 12, 2026
Merged

danroth27 merged 2 commits into
mainfrom
maintenance/tcort-markdown-link-check

Conversation

@danroth27

@danroth27 danroth27 commented Oct 11, 2026 •

Copy link
Copy Markdown
Member

Summary

Fixes #10633.

Replace the archived gaurav-nelson/github-action-markdown-link-check@v1 action with tcort/github-action-markdown-link-check@v1, matching the existing major-version-tag style.

The old action tag installs markdown-link-check 3.8.7, whose browser User-Agent triggers a Google authentication redirect loop for the valid Android 12L URL. This caused the push link check associated with #10610 to fail twice. The maintained fork currently installs 3.15.0, which checked that URL successfully locally without a User-Agent override or exclusion.

All existing workflow inputs, permissions, triggers, check names, file-selection scope, and JSON configuration remain unchanged. No changes are made to #10610.

Validation

  • YAML parses; a structural comparison confirms only the action reference changed. git diff --check passed.
  • Focused Checkov scan of the modified workflow passed: 15 checks, no failures.
  • README link check passed: 23 links.
  • Repository-wide Markdown linting failed on existing release-note formatting errors; no Markdown files are changed here.
  • Repository-wide Checkov failed on the existing copilot-setup-steps.yml permissions check and reported parsing/encoding issues in other files. The changed workflow passed its focused scan.
  • Repository-wide Prettier reported existing formatting issues in 5,385 files; no bulk formatting changes are included.

CI limitations

The current workflow triggers only for Markdown changes, so this workflow-only PR does not automatically exercise the link checker. The new action and allowed-actions compatibility still need CI confirmation. The Actions policy API returned HTTP 403 for the current credentials. Rerunning the historical failed run uses its old workflow and will not test this update.

Copilot AI added 2 commits October 10, 2026 19:43
Replace the archived action with the pinned v1.1.2 tcort fork while preserving existing inputs and configuration.

Fixes #10633

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: aa8f7290-9f51-4d4e-8022-e60a39bfa016
Follow the maintained major-version tag rather than pinning the v1.1.2 commit.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: aa8f7290-9f51-4d4e-8022-e60a39bfa016
@danroth27
danroth27 requested review from jeffhandley and jongalloway and a balanced review from Copilot October 11, 2026 02:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The replacement action exposes compatible inputs and the focused change fulfills the linked issue without altering workflow behavior.

0 open findings

What changed in this PR

Replaces the archived Markdown link-check action with its maintained fork while preserving existing workflow behavior.

Changes:

  • Updates the action reference to tcort/github-action-markdown-link-check@v1.
  • Retains all triggers, permissions, inputs, and link-check scope.
File Description
.github/​workflows/​markdown-link-check.yml Uses the maintained link-check action fork.

🧠 Review effort: Balanced


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@danroth27
danroth27 merged commit 0de22fd into main Oct 12, 2026
10 checks passed
@danroth27
danroth27 deleted the maintenance/tcort-markdown-link-check branch October 12, 2026 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace archived Markdown link-check action with maintained tcort fork

4 participants