Tests ran counter #111145
Tests ran counter #111145
Conversation
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/gc |
| @@ -22,6 +22,7 @@ | |||
| using System.Linq; | |||
|
|
|||
| using System.Runtime.Loader; | |||
| using Microsoft.CodeAnalysis.CSharp.Syntax; | |||
| public void RecordTestRanCount() | ||
| { | ||
| StringBuilder sb = new(); | ||
| foreach(var item in _testRanCounter) |
There was a problem hiding this comment.
When called via the CancelKeyPress event, the test will still be running while this code executes. Use _testRanCounterLock here.
| if (!_testRanCounter.Keys.Contains(testRefOrID)) | ||
| { | ||
| _testRanCounter[testRefOrID] = 0; | ||
| } | ||
| _testRanCounter[testRefOrID] ++; |
There was a problem hiding this comment.
(purely a style comment)
You can use _testRanCounter[testRefOrId] = _testRanCounter.GetValueOrDefault(testRefOrId, 0) + 1
(you can even leave off the 0 and use the other GetValueOrDefault overload since 0 is the default value for uint)
| sb.AppendLine($"{item.Key}: {item.Value}"); | ||
| } | ||
| } | ||
| _logger.WriteToInstrumentationLog(_curTestSet, LoggingLevels.StartupShutdown, $"Tests ran count:\n{sb}"); |
| @@ -161,6 +163,11 @@ public static int Main(string[] args) | |||
|
|
|||
| ReliabilityFramework rf = new ReliabilityFramework(); | |||
| rf._logger.WriteToInstrumentationLog(null, LoggingLevels.StartupShutdown, "Started"); | |||
|
|
|||
| Console.CancelKeyPress += (object sender, ConsoleCancelEventArgs args) => { | |||
There was a problem hiding this comment.
NIT: Since you aren't using either of the parameters of the delegate, you could easily set them to _ to indicate that they aren't used i.e.,
csharp Console.CancelKeyPress += (object _, ConsoleCancelEventArgs _) => { .. }
| @@ -314,6 +321,19 @@ public static int Main(string[] args) | |||
| return (retVal); | |||
| } | |||
|
|
|||
| public void RecordTestRanCount() | |||
There was a problem hiding this comment.
NIT: The name RecordTestRunCount seems more apt.
Record how many times each test ran for. (even if the run is terminated manually)