ApiDiff: Move TryGetRecordConstructor from GenAPI.INamedTypeSymbolExtensions up to ApiSymbolExtensions.SymbolExtensions #45801
+32
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ymbolExtesions up to Microsoft.DotNet.ApiSymbolExtensions.SymbolExtensions.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
ViktorHofer
reviewed
Jan 9, 2025
Comment on lines
+131
to
+134
| // Locates constructor generated by the compiler for `record Foo(...)` syntax | ||
| // If the type is a record and the compiler generated constructor is found it will be returned, otherwise null. | ||
| // The compiler will not generate a constructor in the case where the user defined it themself without using an argument list | ||
| // in the record declaration, or if the record has no parameters. |
There was a problem hiding this comment.
Please change this to triple slash comments as this method and type is public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of the work needed to create an ApiDiff tool that reuses some of the code from Microsoft.DotNet.GenAPI. The idea is to make the larger PR smaller and make it easier to review: #45389
This change moves an extension method from the Microsoft.DotNet.GenAPI project to the higher Microsoft.DotNet.ApiSymbolExtensions.SymbolExtensions project, so it's available more generally.
PR #45806 depends on this change being merged first.