Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Proposal) [#264] media3 integration #266
(Proposal) [#264] media3 integration #266
Changes from 32 commits
4d024e6
69cb906
3c0e6ef
7495ff4
ef74596
e3ce3fe
b4504e6
145707a
8fde836
c684829
dce8d02
9a5e251
64f7472
9190130
a31c1c0
a399cf8
baa6902
172945e
01ef8b9
8897b93
4fda44b
a6239cf
b6c95ec
11f16f3
1ac9923
3be75f9
6cd0f3a
c55d900
93c5e6a
ab565ef
7d9204d
8f3638c
ef0a703
99b5a04
35a16d2
9955684
8f4377c
eb2781b
d905dc4
e788ab6
649e73c
29674ec
aec471e
2263e4c
bb6dc76
e4ad4f1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOTE: SessionActivityIntentProvider interface의 구현체를 주입하기 위함인데 본 레퍼런스에선 이런 분리를 세세하게 고민하지 않았던 편.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
질문) 이 class의 목적이 어떻게 될까요?
PendingIntent를 생성하는거라면 exteions 형태로 만들어도 충분할것 같아보입니다.
객체 형태로 만들어져 있어야할 이유가 있을까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/droidknights/DroidKnights2023_App/pull/266/files/7d9204d899004c7b001fd1a4adb74721980fa591#diff-281b1044609ea759a0253956cdbac7889c69d2c1b66a445f36702e59f495c2a4R74-R81
core:playback module에서 MediaLibrarySession.Builder에서 MediaSession 클릭 시 사용자를 이동시키기 위한 setSessionActivity method에 쓰입니다. 각 앱마다 동작이 다르기에 interface를 선언하고 각 앱마다 다른 구현체를 넣어줬습니다.