This repository has been archived by the owner on Mar 26, 2020. It is now read-only.
Make #379 compatible with python branch #388
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the CDPATH environment variable is set, the cd command prints the path of the directory to stdout. Redirect that output to /dev/null to avoid it being mistakenly included in the base_dir variable, which then causes cryptic errors.
* Implement comments support, tests and readme documentation * improve code comments and documents comments parser when the two types of comments are one after the other * improve tests
# Conflicts: # test-suite/djinni/client_interface.djinni # test-suite/djinni/multiple_inheritance.djinni # test-suite/generated-src/cpp/second_listener.hpp # test-suite/generated-src/java/com/dropbox/djinni/test/SecondListener.java # test-suite/generated-src/objc/DBSecondListener.h
|
@4brunu please take a look to see if anything should be adjusted, thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging master branch to python branch, the python compile failed because of the update in #379.
So I made another commit 875bbe2 to update
PythonGenerator.scala, so that it can make use of the updated Doc objectThe only commit that matters here is 875bbe2, while the previous commits are just merged commits from master branch