Enable credentials import promo for all users #1014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
commented
Oct 10, 2024
| @@ -91,7 +91,10 @@ public class WebsiteAutofillUserScript: AutofillUserScript { | |||
| } | |||
| // Sets the last message host, so we can check when it messages back | |||
| lastOpenHost = hostProvider.hostForMessage(message) | |||
| passwordImportDelegate?.autofillUserScriptWillDisplayOverlay(serializedInputContext) | |||
| if passwordImportDelegate?.autofillUserScriptShouldDisplayOverlay(serializedInputContext) != true { | |||
There was a problem hiding this comment.
To block the overlay if the permanent dismissal flag has been set
…prompt-for-all-users
graeme
commented
Oct 16, 2024
| @@ -259,24 +186,12 @@ class AutofillUserScriptTests: XCTestCase { | |||
|
|
|||
| // MARK: Private | |||
|
|
|||
| // Default vaules here are those that will result in a `true` value for credentialsImport. Override to test `false` case. | |||
There was a problem hiding this comment.
I moved all this to the app
amddg44
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1202926619870900/1208282574906775/f
iOS PR: duckduckgo/iOS#3427
macOS PR: duckduckgo/macos-browser#3383
What kind of version bump will this require?: Major
Optional:
Task/Issue URL: https://app.asana.com/0/1202926619870900/1208282574906775/f
Tech Design URL: https://app.asana.com/0/1202926619870900/1208502988382869/f
Description:
We're rolling out ✓ Promote password import in autofill menu [2w] and the conversion rate seems pretty decent. If we expand the addressable userbase we're likely to improve the user experience of many more users.
With ✓ Promote password import in autofill menu [2w] we're promoting import to <7 days users with less than 10 passwords saved.
To make this promotion even more impactful, we can expand the coverage to existing users, but to make it impactful we'll need more lax heuristics and a way for users to dismiss this promo.
Steps to test this PR:
Test Instructions
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template