Include www.youtube.com as Youtube host #1028
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bunn
approved these changes
Oct 22, 2024
<!-- Note: This checklist is a reminder of our shared engineering expectations. --> Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: iOS PR: macOS PR: What kind of version bump will this require?: Major/Minor/Patch **Optional**: Tech Design URL: CC: **Description**: <!-- Tagging instructions If this PR isn't ready to be merged for whatever reason it should be marked with the `DO NOT MERGE` label (particularly if it's a draft) If it's pending Product Review/PFR, please add the `Pending Product Review` label. If at any point it isn't actively being worked on/ready for review/otherwise moving forward (besides the above PR/PFR exception) strongly consider closing it (or not opening it in the first place). If you decide not to close it, make sure it's labelled to make it clear the PRs state and comment with more information. --> **Steps to test this PR**: 1. 1. <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943) Co-authored-by: Shane Osbourne <[email protected]>
Task/Issue URL: https://app.asana.com/0/0/1208077416568652/f iOS PR: duckduckgo/iOS#3492 macOS PR: duckduckgo/macos-browser#3415 What kind of version bump will this require?: Minor **Description**: Updates C-S-S and adds privacy feature
Please review the release process for BrowserServicesKit [here](https://app.asana.com/0/1200194497630846/1200837094583426). **Required**: Task/Issue URL: https://app.asana.com/0/1108686900785972/1208264562025859/f iOS PR: duckduckgo/iOS#3488 macOS PR: duckduckgo/macos-browser#3458 What kind of version bump will this require?: Minor **Description**: Store and keep in sync the subscription access token for the duckduckgo.com domain cookie. For the implementation guidelines please see description of the linked task. **Steps to test this PR**: See platform PRs **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
samsymons
added a commit
that referenced
this pull request
Nov 1, 2024
…the-os * main: Bump github.com/duckduckgo/privacy-dashboard from 5.3.0 to 7.1.1 (#1046) Bump github.com/duckduckgo/sync_crypto from 0.2.0 to 0.3.0 (#1048) Bump github.com/1024jp/gzipswift from 6.0.1 to 6.1.0 (#1050) Update to subscription cookie (#1053) Bug Fix: Phishing Detection Dataset Discrepancies (#1032) Include www.youtube.com as Youtube host (#1028)
samsymons
added a commit
that referenced
this pull request
Nov 4, 2024
* main: Validate VPN errors before re-throwing them (#1054) Allowing users to delete suggestions (#1027) Revert "Bump github.com/1024jp/gzipswift from 6.0.1 to 6.1.0" (#1055) Bump github.com/duckduckgo/privacy-dashboard from 5.3.0 to 7.1.1 (#1046) Bump github.com/duckduckgo/sync_crypto from 0.2.0 to 0.3.0 (#1048) Bump github.com/1024jp/gzipswift from 6.0.1 to 6.1.0 (#1050) Update to subscription cookie (#1053) Bug Fix: Phishing Detection Dataset Discrepancies (#1032) Include www.youtube.com as Youtube host (#1028) Ignore GRDB (#1052) Connect refactored update flow to the new release notes page (#1025) Add to Dock - Add extra custom view to Contextual Dialog Content (#1043) Dependabot for BSK (#1045) Update autofill to 15.1.0 (#1044)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208593005609709/f
iOS PR: duckduckgo/iOS#3455
macOS PR: duckduckgo/macos-browser#3434
What kind of version bump will this require?: Minor
Description:
We were missing www.youtube.com as a valid host for Youtube.