Add support for local overrides for feature flags #1074
Merged
+642
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ayoy
requested review from
diegoreymendez
and removed request for
SabrinaTardio
diegoreymendez
approved these changes
Nov 14, 2024
samsymons
added a commit
that referenced
this pull request
Nov 14, 2024
samsymons
added a commit
that referenced
this pull request
Nov 18, 2024
mgurgel
pushed a commit
that referenced
this pull request
Nov 18, 2024
Task/Issue URL: https://app.asana.com/0/72649045549333/1208716221426945/f Tech Design URL: https://app.asana.com/0/481882893211075/1208716218352496/f Description: This change adds FeatureFlagLocalOverrides class that is owned by DefaultFeatureFlagger and allow for setting local overrides for feature flags. This is supported only for internal users and is opt-in for all feature flags. Currently disabled for all flags but HTML New Tab Page on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/72649045549333/1208716221426945/f
iOS PR: duckduckgo/iOS#3571
macOS PR: duckduckgo/macos-browser#3545
What kind of version bump will this require?: Major
Optional:
Tech Design URL: https://app.asana.com/0/481882893211075/1208716218352496/f
CC: @diegoreymendez
Description:
This change adds FeatureFlagLocalOverrides class that is owned by DefaultFeatureFlagger
and allow for setting local overrides for feature flags. This is supported only for internal users
and is opt-in for all feature flags. Currently disabled for all flags but HTML New Tab Page on macOS.
Steps to test this PR:
See macOS PR for steps to test. iOS PR is good to go as soon as CI is green.
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template