Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML New Tab Page Privacy Config feature for macOS #1152

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

ayoy
Copy link
Contributor

@ayoy ayoy commented Jan 9, 2025

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/0/1209105499479210/f
iOS PR: duckduckgo/iOS#3780
macOS PR: duckduckgo/macos-browser#3715
What kind of version bump will this require?: Minor

Description:
This change adds a new case to the PrivacyFeature enum.

Steps to test this PR:
Verify that CI is green.

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16
  • macOS 10.15
  • macOS 11
  • macOS 12

Internal references:

Software Engineering Expectations
Technical Design Template

@ayoy ayoy self-assigned this Jan 9, 2025
@ayoy ayoy marked this pull request as ready for review January 9, 2025 08:42
@ayoy ayoy requested a review from SabrinaTardio January 9, 2025 09:00
@ayoy ayoy assigned SabrinaTardio and unassigned ayoy Jan 9, 2025
Copy link
Contributor

@SabrinaTardio SabrinaTardio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ayoy ayoy merged commit 4f591a8 into main Jan 9, 2025
7 checks passed
@ayoy ayoy deleted the dominik/html-ntp-feature branch January 9, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants