Add tests for DomActions.prehide() #552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freiondrej
force-pushed
the
dom-actions-wtr-prehide
branch
from
8c767e4 to
c72900e
Compare
muodov
reviewed
Jan 10, 2025
| domActions = instantiateDomActions(); | ||
| }); | ||
|
|
||
| it('returns false when selector is empty string', () => { |
There was a problem hiding this comment.
interesting, empty selector was never supposed to be passed here I think. In fact, right now it produces an invalid CSS in the style tag.
Invalid CSS is ignored by the browser, and we don't pass empty selectors anyways, so it's not a big deal. But we should clean it up some day, and handle empty selectors in this method.
muodov
approved these changes
Jan 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in the mini README, I had to split the tests into multiple files, as I didn't find any option of WTR to refresh files between runs.
I suppose potentially we could introduce such logic ourselves by using the "barebones" variant of html tests (the 2nd code snippet in this page), where
runTestswould be replaced by direct calls to specific test cases and we would perform a reload after each of them, but I'm not sure it's worth it, let me know if I should give it a try 🚀EDIT: Or, we could leverage undoPrehide() to get rid of the element again. However, I'm not sure if we want to couple the tests to its implementation like that.