Expand persistent pixel usage (#3596)

Task/Issue URL: https://app.asana.com/0/72649045549333/1208802635345012/f Tech Design URL: CC: Description: This PR updates pixel persistence to cover server migration and tunnel updates.
duckduckgo · Nov 22, 2024 · 3525099 · 3525099
1 parent 7b3b63d
commit 3525099
Showing 1 changed file with 36 additions and 14 deletions.
diff --git a/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift b/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift
@@ -212,15 +212,26 @@ final class NetworkProtectionPacketTunnelProvider: PacketTunnelProvider {
 
             switch step {
             case .begin:
-                DailyPixel.fireDailyAndCount(pixel: .networkProtectionTunnelUpdateAttempt,
-                                             pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes)
+                persistentPixel.fireDailyAndCount(
+                    pixel: .networkProtectionTunnelUpdateAttempt,
+                    pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes,
+                    error: nil,
+                    withAdditionalParameters: [:],
+                    includedParameters: [.appVersion]) { _ in }
             case .failure(let error):
-                DailyPixel.fireDailyAndCount(pixel: .networkProtectionTunnelUpdateFailure,
-                                             pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes,
-                                             error: error)
+                persistentPixel.fireDailyAndCount(
+                    pixel: .networkProtectionTunnelUpdateFailure,
+                    pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes,
+                    error: error,
+                    withAdditionalParameters: [:],
+                    includedParameters: [.appVersion]) { _ in }
             case .success:
-                DailyPixel.fireDailyAndCount(pixel: .networkProtectionTunnelUpdateSuccess,
-                                             pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes)
+                persistentPixel.fireDailyAndCount(
+                    pixel: .networkProtectionTunnelUpdateSuccess,
+                    pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes,
+                    error: nil,
+                    withAdditionalParameters: [:],
+                    includedParameters: [.appVersion]) { _ in }
             }
         case .tunnelWakeAttempt(let step):
             vpnLogger.log(step, named: "Tunnel Wake")
@@ -259,15 +270,26 @@ final class NetworkProtectionPacketTunnelProvider: PacketTunnelProvider {
 
             switch step {
             case .begin:
-                DailyPixel.fireDailyAndCount(pixel: .networkProtectionServerMigrationAttempt,
-                                             pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes)
+                persistentPixel.fireDailyAndCount(
+                    pixel: .networkProtectionServerMigrationAttempt,
+                    pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes,
+                    error: nil,
+                    withAdditionalParameters: [:],
+                    includedParameters: [.appVersion]) { _ in }
             case .failure(let error):
-                DailyPixel.fireDailyAndCount(pixel: .networkProtectionServerMigrationAttemptFailure,
-                                             pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes,
-                                             error: error)
+                persistentPixel.fireDailyAndCount(
+                    pixel: .networkProtectionServerMigrationAttemptFailure,
+                    pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes,
+                    error: error,
+                    withAdditionalParameters: [:],
+                    includedParameters: [.appVersion]) { _ in }
             case .success:
-                DailyPixel.fireDailyAndCount(pixel: .networkProtectionServerMigrationAttemptSuccess,
-                                             pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes)
+                persistentPixel.fireDailyAndCount(
+                    pixel: .networkProtectionServerMigrationAttemptSuccess,
+                    pixelNameSuffixes: DailyPixel.Constant.legacyDailyPixelSuffixes,
+                    error: nil,
+                    withAdditionalParameters: [:],
+                    includedParameters: [.appVersion]) { _ in }
             }
         case .tunnelStartOnDemandWithoutAccessToken:
             vpnLogger.logStartingWithoutAuthToken()