Display short URL when not editing #2357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brindy
reviewed
Jan 22, 2024
| } | ||
| } | ||
|
|
||
| static func deemphasisePath(forUrl url: URL) -> NSAttributedString { |
There was a problem hiding this comment.
I'm not sure we need this now do we? The point of this was to make everything after the first slash slightly lighter but we're not showing that any more. When the user is editing it should all be the same colour anyway imo (I don't think anyone expects the text to be demphasised while editing).
There was a problem hiding this comment.
I had mixed feelings about this part too, but ended up leaving it as it is since the text appearance was not updated while editing - that made me believe it’s intentional behavior.
brindy
requested changes
Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206226850447395/1205485701057249
Description:
Displays a short URL (hostname without
wwwcomponent), while browsing. While short URL is displayed, the text alignment is adjusted to the center.Steps to test this PR:
Theme Testing: