Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP errors and status codes to site breakage reports #2477

Merged
merged 10 commits into from
Feb 22, 2024

Conversation

SlayterDev
Copy link
Contributor

@SlayterDev SlayterDev commented Feb 14, 2024

Task/Issue URL: https://app.asana.com/0/414235014887631/1206604819945148/f
Tech Design URL:
CC:

Description:

Steps to test this PR:

  1. Load https://expired.badssl.com/
  2. Put a breakpoint on Line 202 of PrivacyDashboardViewController.swift and send report
  3. Validate that the report contains errorDescriptions
  4. Validate that the report contains httpErrorCodes too

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Internal references:

Software Engineering Expectations
Technical Design Template

@SlayterDev SlayterDev self-assigned this Feb 14, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 14, 2024
@SlayterDev SlayterDev removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Feb 15, 2024
@SlayterDev SlayterDev marked this pull request as ready for review February 15, 2024 18:57
@SlayterDev SlayterDev merged commit a27e6d5 into main Feb 22, 2024
13 checks passed
@SlayterDev SlayterDev deleted the brad/error-code-updates branch February 22, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants