Improve VPN rekeying reliability #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
diegoreymendez
approved these changes
Feb 17, 2024
# By Diego Rey Mendez # Via GitHub * main: Updates BSK (#2448) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 18, 2024
Required: Task/Issue URL: https://app.asana.com/0/414235014887631/1206607513978260/f iOS PR: duckduckgo/iOS#2478 macOS PR: duckduckgo/macos-browser#2207 What kind of version bump will this require?: Major Description: This PR fixes three issues: The rekeying implementation was deleting the old key, and then registering a new one - however, if the registration call failed, then it got left in a confused state with a connection that didn't work The connection tester is what is responsible for triggering rekeying and the DAU pixel, but it was accidentally setting isRunning to false even when it was running just fine The DAU event was sent only when the connection was idle, which isn't necessary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206607513978260/f
Tech Design URL:
CC:
Description:
Client PR for duckduckgo/BrowserServicesKit#664
Steps to test this PR:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template