Malicious site protection address bar and privacy dashboard changes #3718
Conversation
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-navigation-detection-async
branch
from
b6dbf5c to
5c07c05
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-address-bar-and-privacy-dashboard
branch
from
95a56b5 to
014ea13
Compare
| if privacyInfo.isSpecialErrorPageVisible { | ||
| showCustomIcon(icon: .specialError) | ||
| return | ||
| } |
There was a problem hiding this comment.
how does it look like for ssl error page now? I remember decision was not to show any icon, are we good there?
There was a problem hiding this comment.
Before this change we didn’t show any icon. We agreed to show the same icon for the special error pages, SSL included.
| case daxLogo, shield, shieldWithDot | ||
| case daxLogo, shield, shieldWithDot, alert | ||
|
|
||
| fileprivate var staticImage: UIImage? { |
There was a problem hiding this comment.
Probably not a great name if it raises questions. As shield and shieldWithDot are animated I was looking for a name that would give the idea of a “static” image without animation. I’ll find a better name
There was a problem hiding this comment.
maybe static makes sense in this context, even the imageView was named staticImageView. Let me know if you can think of a better name
| @@ -1064,6 +1064,7 @@ class TabViewController: UIViewController { | |||
| let privacyInfo = PrivacyInfo(url: url, | |||
| parentEntity: entity, | |||
| protectionStatus: makeProtectionStatus(for: host), | |||
| malicousSiteThreatKind: specialErrorPageNavigationHandler.currentThreatKind, | |||
There was a problem hiding this comment.
Do you mind if I do this fix as a separate PR? I noticed it's an existing typo made in few different places. I will fix it in BSK and then make a PR for iOS and macOS. But because this PR is pointing at specific branch for privacy dashboard it’s a bit tricky to do this fix unless I merge that one first. As I’m merging this PR in my main feature branch there are no issues to merge the PR pointing at that branch. I will ensure it points at exact version before ship review.
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions. |
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-navigation-detection-async
branch
from
5c07c05 to
c3dbd41
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-address-bar-and-privacy-dashboard
branch
from
014ea13 to
b4d4dd0
Compare
Task/Issue URL: https://app.asana.com/0/1206329551987282/1208959082985728/f
Tech Design: https://app.asana.com/0/1206329551987282/1207273224076495/f
CC: @not-a-rootkit
Description:
This PR addresses the following:
Steps to test this PR:
Scenario 1 - Special Error Pages show globe icon in the address bar
Ensure that the below URLs show the globe icon in the Address Bar as per Figma Design
Scenario 2 - Malicious Sites show alert icon in the address bar
a. http://privacy-test-pages.site/security/badware/phishing.html
b. http://privacy-test-pages.site/security/badware/malware.html
Scenario 3 - Malicious Sites show updated privacy dashboard
a. http://privacy-test-pages.site/security/badware/phishing.html
b. http://privacy-test-pages.site/security/badware/malware.html
Scenario 4 - Accepting visiting SSL Insecure website (Bonus Point)
Definition of Done (Internal Only):
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template