Skip to content

Improve VPN rekeying reliability #7565

Improve VPN rekeying reliability

Improve VPN rekeying reliability #7565

Re-run triggered February 18, 2024 19:28
Status Success
Total duration 6m 48s
Artifacts

pr.yml

on: pull_request
Matrix: Test
Matrix: Make Release Build
SwiftLint
55s
SwiftLint
Verify autoconsent bundle
11s
Verify autoconsent bundle
ShellCheck
6s
ShellCheck
Private API Report  /  Update PR comment
5s
Private API Report / Update PR comment
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

54 warnings and 2 notices
Verify autoconsent bundle
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-node@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Make Release Build (DuckDuckGo Privacy Pro)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Make Release Build (DuckDuckGo Privacy Pro): CoreData#L1
no NSValueTransformer with class name 'NSStringTransformer' was found for attribute 'titleEncrypted' on entity 'HistoryEntryManagedObject'
Make Release Build (DuckDuckGo Privacy Pro): CoreData#L1
no NSValueTransformer with class name 'NSImageTransformer' was found for attribute 'faviconEncrypted' on entity 'BookmarkManagedObject'
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Sharing/SharingMenu.swift#L77
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Sharing/SharingMenu.swift#L79
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Tab/UserScripts/SubscriptionPagesUserScript.swift#L122
immutable value 'accessToken' was never used; consider replacing with '_' or removing it
Make Release Build (DuckDuckGo Privacy Pro): DuckDuckGo/Menus/MainMenuActions.swift#L110
result of call to 'restoreLastSessionState(interactive:)' is unused
Make Release Build (DuckDuckGo Privacy Browser)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Make Release Build (DuckDuckGo Privacy Browser): CoreData#L1
no NSValueTransformer with class name 'NSStringTransformer' was found for attribute 'titleEncrypted' on entity 'HistoryEntryManagedObject'
Make Release Build (DuckDuckGo Privacy Browser): CoreData#L1
no NSValueTransformer with class name 'NSImageTransformer' was found for attribute 'faviconEncrypted' on entity 'BookmarkManagedObject'
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/Sharing/SharingMenu.swift#L77
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/Sharing/SharingMenu.swift#L79
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/Menus/MainMenuActions.swift#L110
result of call to 'restoreLastSessionState(interactive:)' is unused
Make Release Build (DuckDuckGo Privacy Browser): DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/Invite/NetworkProtectionInviteDialog.swift#L42
weak reference will always be nil because the referenced object is deallocated here
Test (Non-Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Non-Sandbox)
not stripping binary because it is signed: /Users/runner/work/macos-browser/macos-browser/DerivedData/SourcePackages/artifacts/grdb.swift/GRDB/GRDB.xcframework/macos-arm64_x86_64/GRDB.framework/Versions/A/GRDB (in target 'DataBrokerProtectionTests' from project 'DataBrokerProtection')
Test (Non-Sandbox): CoreData#L1
no NSValueTransformer with class name 'NSStringTransformer' was found for attribute 'titleEncrypted' on entity 'HistoryEntryManagedObject'
Test (Non-Sandbox): CoreData#L1
no NSValueTransformer with class name 'NSImageTransformer' was found for attribute 'faviconEncrypted' on entity 'BookmarkManagedObject'
Test (Non-Sandbox): DuckDuckGo/Menus/MainMenuActions.swift#L110
result of call to 'restoreLastSessionState(interactive:)' is unused
Test (Non-Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L77
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
Test (Non-Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L79
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
Test (Non-Sandbox): DerivedData/Build/Products/CI/OpenSSL.framework/Headers/shim.h#L12
a function declaration without a prototype is deprecated in all versions of C [-Wstrict-prototypes]
Test (Non-Sandbox)
DuckDuckGoDBPBackgroundAgent isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgent' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoVPN isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoVPN' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGo Privacy Browser isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser' from project 'DuckDuckGo')
Test (Non-Sandbox)
DuckDuckGoNotifications isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoNotifications' from project 'DuckDuckGo')
Test (Sandbox)
Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/cache@v3, mikepenz/action-junit-report@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
Test (Sandbox)
DuckDuckGoDBPBackgroundAgentAppStore isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGoDBPBackgroundAgentAppStore' from project 'DuckDuckGo')
Test (Sandbox)
Run script build phase 'Copy Swift Package resources' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'DuckDuckGoDBPBackgroundAgentAppStore' from project 'DuckDuckGo')
Test (Sandbox)
Run script build phase 'Run Script' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'DuckDuckGoVPNAppStore' from project 'DuckDuckGo')
Test (Sandbox)
DuckDuckGo Privacy Browser App Store isn't code signed but requires entitlements. It is not possible to add entitlements to a binary without signing it. (in target 'DuckDuckGo Privacy Browser App Store' from project 'DuckDuckGo')
Test (Sandbox)
Run script build phase 'Embed Login Items' will be run during every build because it does not specify any outputs. To address this warning, either add output dependencies to the script phase, or configure it to run in every build by unchecking "Based on dependency analysis" in the script phase. (in target 'DuckDuckGo Privacy Browser App Store' from project 'DuckDuckGo')
Test (Sandbox): DerivedData/Build/Products/CI/GRDB.framework/PrivateHeaders/grdb_config.h#L14
ambiguous expansion of macro 'SQLITE_VERSION_NUMBER'
Test (Sandbox): CoreData#L1
no NSValueTransformer with class name 'NSStringTransformer' was found for attribute 'titleEncrypted' on entity 'HistoryEntryManagedObject'
Test (Sandbox): CoreData#L1
no NSValueTransformer with class name 'NSImageTransformer' was found for attribute 'faviconEncrypted' on entity 'BookmarkManagedObject'
Test (Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L77
'open(_:withAppBundleIdentifier:options:additionalEventParamDescriptor:launchIdentifiers:)' was deprecated in macOS 11.0: Use -[NSWorkspace openURLs:withApplicationAtURL:configuration:completionHandler:] instead.
Test (Sandbox): DuckDuckGo/Sharing/SharingMenu.swift#L79
'async' was deprecated in macOS 11.0: When using NSWorkspaceOpenConfiguration, all launches are asynchronous.
Test (Sandbox): DuckDuckGo/Menus/MainMenuActions.swift#L110
result of call to 'restoreLastSessionState(interactive:)' is unused
Test (Sandbox): DuckDuckGo/NetworkProtection/AppTargets/BothAppTargets/VPNLocation/VPNLocationPreferenceItem.swift#L62
'animation' was deprecated in macOS 12.0: Use withAnimation or animation(_:value:) instead.
Test (Sandbox): DuckDuckGo/Common/Utilities/HardwareModel.swift#L25
'kIOMasterPortDefault' was deprecated in macOS 12.0: renamed to 'kIOMainPortDefault'
Test (Sandbox): DuckDuckGo/Preferences/View/PreferencesSidebar.swift#L72
getter 'body' took 352ms to type-check (limit: 250ms)
Test (Non-Sandbox)
Tests Passed: 0 failed, 0 skipped, 191 total (13.905 seconds)
Test (Sandbox)
Tests Passed: 0 failed, 0 skipped, 9 total (0.078 seconds)