Skip to content

Commit

Permalink
Update Xcode version to 15.4 (#3023)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/1203301625297703/1207895930258170/f

Description:
Update .xcode-version to indicate Xcode 15.4 as the officially supported version.
  • Loading branch information
ayoy authored Jul 25, 2024
1 parent 727561d commit b6c2864
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build_appstore.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ jobs:

name: Make App Store Connect Release

runs-on: macos-13-xlarge
runs-on: macos-14-xlarge

env:
destination: ${{ github.event.inputs.destination || inputs.destination }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_hotfix_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ jobs:
name: Update Asana tasks

needs: run_tests
runs-on: macos-13-xlarge
runs-on: macos-14-xlarge
timeout-minutes: 10

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/build_notarized.yml
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ jobs:

name: Export Notarized App

runs-on: macos-13-xlarge
runs-on: macos-14-xlarge

outputs:
app-version: ${{ steps.set-outputs.outputs.app-version }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/bump_internal_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ jobs:
name: Increment Build Number

needs: [ validate_input_conditions, run_tests ]
runs-on: macos-13-xlarge
runs-on: macos-14-xlarge
timeout-minutes: 10

steps:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/code_freeze.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

name: Create Release Branch

runs-on: macos-13-xlarge
runs-on: macos-14-xlarge
timeout-minutes: 10

outputs:
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
name: Increment Build Number

needs: [ create_release_branch, run_tests ]
runs-on: macos-13-xlarge
runs-on: macos-14-xlarge
timeout-minutes: 10

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/hotfix.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

name: Create Release Branch

runs-on: macos-13-xlarge
runs-on: macos-14-xlarge
timeout-minutes: 10

outputs:
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,7 @@ jobs:
- cache-key: sandbox-
flavor: Sandbox

runs-on: macos-13-xlarge
runs-on: macos-14-xlarge
timeout-minutes: 30

outputs:
Expand Down Expand Up @@ -288,7 +288,7 @@ jobs:
# workflow_call is used by bump_internal_release and is followed by a proper release job
if: github.actor != 'dependabot[bot]' && (github.event_name == 'push' || github.event_name == 'pull_request')

runs-on: macos-13-xlarge
runs-on: macos-14-xlarge
timeout-minutes: 30

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/publish_dmg_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ jobs:
# or failed (for public releases or hotfixes), because tagging doesn't block publishing the release
if: always()

runs-on: macos-13-xlarge
runs-on: macos-14-xlarge
timeout-minutes: 10

steps:
Expand Down
2 changes: 1 addition & 1 deletion .xcode-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
15.2
15.4
4 changes: 4 additions & 0 deletions DuckDuckGo/RemoteMessaging/RemoteMessagingDebugMenu.swift
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,10 @@ final class RemoteMessagingDebugMenu: NSMenu {
removeItem(at: 3)
}

guard NSApplication.runType.requiresEnvironment else {
return
}

let database = NSApp.delegateTyped.remoteMessagingClient.database
let context = database.makeContext(concurrencyType: .mainQueueConcurrencyType)
let fetchRequest = RemoteMessageManagedObject.fetchRequest()
Expand Down

0 comments on commit b6c2864

Please sign in to comment.