Add support for conditional clicking

[brianhall]

Task/Issue URL: https://app.asana.com/0/1199230911884351/1208647902506360/f
Tech Design URL:
CC:

Description:

Adds support for conditional clicking of elements by adding “choices” and “default” keys to the click action.

Optional E2E tests:

• Run PIR E2E tests
  Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.

Steps to test this PR:
The easiest way to test whether the decoding is working is to setup one of the test files from the C-S-S integration tests as a fake broker:

1. Download this file on your local machine. Open it to copy the file path, should start with file://
2. Download this JSON and update the url to the file path you copied in 1.
3. Save the JSON file in the macos-browser repo under LocalPackages/DataBrokerProtection/Sources/DataBrokerProtection/Resources/JSON
4. Build the browser (no need for any special dependencies, just build main), then open the debug version of PIR: Debug Menu -> Personal Information Removal -> Run Personal Information Removal in Debug Mode.
5. In Birth Year enter 1965, then select Test Broker in the list of brokers and click the Run button.
6. After about 30 seconds, right click the webview and Inspect Element, then click the console tab and type window.location.href and hit enter. You should see a url that ends with #1, which means that the user was older than 45.
7. Do steps 5-6 again, but for birth year enter 1990, when you do window.location.href you should get a url that ends with #2 instead, indicating that the user is < 45.
8. Edit the mybrokertest.com.json file, copy/paste the contents of this gist in and save. This just sets the default case at the bottom to null. Now re-build the browser to load the updated JSON.
9. Run steps 5-7 again, this time window.location.href should return a url with #1 for step 5, and a url with no # at the end for step 7, meaning that nothing was clicked and no error was triggered.
10. Edit the mybrokertest.com.json file again and remove line 45 (and the comma above on line 44) and then rebuild the browser to update the JSON. Finally steps 5-7 again - step 5 should return no errors (and have a #1 hash at the end of the url), and step 7 should not return an error, but also not have any hash (e.g. #1) at the end of the url.

Definition of Done:

• Does this PR satisfy our Definition of Done?

—

Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

[brianhall]

I need something like this here, but keep getting stuck:

// Explicitly encode `null` if `defaultClick` is nil
if let defaultClick = defaultClick {
  try container.encode(defaultClick, forKey: .defaultClick)
} else {
  try container.encodeNil(forKey: .defaultClick)
}

[github-actions]

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

[github-actions]

This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions.

[THISISDINOSAUR]

@brianhall I've got as far as step #9 when testing, but I'm seeing a URL with #1 at the end. I thought it might be some caching issue, so I tried renaming the test broker, but it still happened

[brianhall]

@THISISDINOSAUR Did you happen to update the JSON in step 8? I should have mentioned it, but you then have to re-build the browser to get the latest JSON. Will add that in the instructions now.

[THISISDINOSAUR]

@brianhall Yeah I did, I tried a clean build too and renaming the that broker just in case it was being cached.
The instructions don't mention doing "update the url to the file path you copied in 1" again after updating the json which I assumed I needed to do (and did), was that correct?

[brianhall]

@THISISDINOSAUR Yep, that’s exactly right. I made a few other updates to the instructions to hopefully make them a bit clearer. Just to clarify, you should see a #1 on the end of the URL when the birth year is 1965, but should see no hash when the birth year is 1990, this is not what you're seeing?