Add Persistence dependency to Crashes module
#3727
Merged
+13
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Jan 13, 2025
Comment on lines
-44
to
+45
| "revision" : "06d244c4e0951ef16217c46f23c4865c5f98dd5c", | ||
| "version" : "7.4.0" | ||
| "revision" : "0502ed7de4130bd8705daebaca9aeb20d3e62d15", | ||
| "version" : "7.5.0" |
There was a problem hiding this comment.
Looks like some of our other dependencies were out of date in Package.resolved, I'm including those bumps here.
6 tasks
Bunn
approved these changes
Jan 13, 2025
samsymons
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 13, 2025
Required: Task/Issue URL: https://app.asana.com/0/1199333091098016/1209143709072898/f iOS PR: duckduckgo/iOS#3797 macOS PR: duckduckgo/macos-browser#3727 What kind of version bump will this require?: Patch Description: This PR updates the Crashes module to use Persistence as a dependency, as it needs it for some of its logic.
samsymons
deleted the
sam/add-persistence-dependency-to-crashes-module
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1199333091098016/1209143709072898/f
Tech Design URL:
CC:
Description:
This PR updates the BSK
Crashesmodule to correctly include relevant dependencies.Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation