Aligning Privacy Dashboard EventMapping with iOS #3744
Merged
+52
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgurgel
changed the title
6 tasks
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
deff857 to
783a83f
Compare
mgurgel
force-pushed
the
mgurgel/improved-breakage-form-pixel
branch
from
0481e40 to
676c605
Compare
mgurgel
force-pushed
the
mgurgel/improved-breakage-form
branch
from
783a83f to
7ea9a8f
Compare
mgurgel
force-pushed
the
mgurgel/improved-breakage-form-pixel
branch
from
1343302 to
9dd2078
Compare
afterxleep
approved these changes
Jan 17, 2025
mgurgel
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 17, 2025
**Required**: Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f iOS PR: duckduckgo/iOS#3822 macOS PR: duckduckgo/macos-browser#3744 What kind of version bump will this require?: Minor **Description**: Implements Privacy Dashboard message `ReportBrokenSiteShown` which will trigger a pixel on macOS and iOS This PR contains a fix for #1160 which is why it is stacked on it. Please let me know if this is not the best way to have this code reviewed. **Steps to test this PR**: 1. Invoke the breakage form in the two possible ways: Open the Privacy Dashboard and click on "Report a problem with this site" Open the app menu ••• and click on "Report Broken Site” (iOS) 2. Confirm that the pixel `m_report-broken-site_shown` was fired 3. Submit a report 4. Confirm that the pixels `epbf` (iOS) / `epbf_macos_desktop` (macOS) and `m_report-broken-site_sent` were fired <!-- Before submitting a PR, please ensure you have tested the combinations you expect the reviewer to test, then delete configurations you *know* do not need explicit testing. Using a simulator where a physical device is unavailable is acceptable. --> **OS Testing**: * [ ] iOS 14 * [ ] iOS 15 * [ ] iOS 16 * [ ] macOS 10.15 * [ ] macOS 11 * [ ] macOS 12 --- ###### Internal references: [Software Engineering Expectations](https://app.asana.com/0/59792373528535/199064865822552) [Technical Design Template](https://app.asana.com/0/59792373528535/184709971311943)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206594217596623/1209173355503842/f
Description:
Set ups Privacy Dashboard EventMapping as to align with iOS. Each mapped event fires a pixel when invoked by the Privacy Dashboard. See duckduckgo/BrowserServicesKit#1167
Note: not all events are currently used by the Dashboard. Some are being deprecated, which is why they might not be fired at all even though they still exist in the mapping.
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Invoke the breakage form in the two possible ways:
Open the Privacy Dashboard and click on "Report a problem with this site"
Open the app menu ••• and click on "Report Broken Site” (iOS)
Confirm that the pixel
m_report-broken-site_shownwas firedSubmit a report
Confirm that the pixels
epbf_macos_desktopandm_report-broken-site_sentwere firedDefinition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation