Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted fixes and updates to HTML New Tab Page #3748

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ayoy
Copy link
Collaborator

@ayoy ayoy commented Jan 18, 2025

Task/Issue URL: https://app.asana.com/0/72649045549333/1209186302756177/f

Description:
This change contains updates to HTML New Tab Page: fixed displaying favicons fetcher
onboarding dialog, added user image background thumbnails context menu
and updated favicon placeholder to 2 letters.

Steps to test this PR:

  1. I've had favicons fetcher onboarding dialog tested and verified already (see this comment in Asana).
  2. Open the app, set internal user state and enable htmlNewTabPage feature flag.
  3. Import some bookmarks and verify that favorites placeholders in New Tab Page display 2 letters.
  4. Set image as background, go to customize panel -> My Backgrounds, verify that image thumbnails have context menu that allows deleting images and that deleting via context menu works.

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

@ayoy ayoy marked this pull request as ready for review January 18, 2025 08:33
@ayoy ayoy requested a review from SabrinaTardio January 18, 2025 08:33
@ayoy ayoy assigned SabrinaTardio and unassigned ayoy Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants