Add code back in #547
Merged
Add code back in #547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duogenesis
force-pushed
the
add-code-back-in
branch
from
1bc20e7 to
17208ff
Compare
duogenesis
commented
Dec 10, 2024
|
|
||
| Whether `X-Forwarded-For` is used or not should probably be configurable in | ||
| Duolicious, but it's currently not. Although hardcoding the solution isn't too | ||
| hard: Simply remove the use of `werkzeug.middleware.proxy_fix.ProxyFix`. |
There was a problem hiding this comment.
I raised a ticket to make this configurable: #548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partly reverts #546.
Also adds a few lines to
DEVELOPER.mdwhich might help @anishsheela to securely configure his prod environment