Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[22518] Fast DDS Auto DS Mode XMLRPC - CLI #5548

Draft
wants to merge 41 commits into
base: master
Choose a base branch
from
Draft

[22518] Fast DDS Auto DS Mode XMLRPC - CLI #5548

wants to merge 41 commits into from

Conversation

cferreiragonz
Copy link
Contributor

Description

This PR updates the CLI to make it compatible with the new Fast DDS Auto Discovery Server Mode using a XML-RPC server to host a daemon.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 8803d40 to 5d6e50e Compare January 8, 2025 10:23
cferreiragonz and others added 29 commits January 8, 2025 14:18
@cferreiragonz
Refs #22013: Add new port offset
a1e6a38 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22013: Add CLI keywords architecture
dfc0ebd 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Python -h/-e args
acdab60 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: 'getDiscoveryServerPort'
d79cba5 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Parse options in main
0c537c7 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Domain (-d) arg
07ac241 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Justify Help message
2aab19a 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Create CliDiscoveryManager & remove server.cpp
21a2c63 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: LIST keyword
674b7a8 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: AUTO keyword
c30ed24 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: STOP keyword
5c423d8 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Update server tests
ce12824 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Refactor SERVER behavior
53a3871 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: ADD keyword
7ad3e04 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Parse ROS_STATIC_PEERS
18b7afb 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: SET keyword & minor fixes
b0310ff 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Uncrustify
0c9a693 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Remove debug log
340d173 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: START keyword & doxygen
0f759b8 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: print Domain ID
b618825 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Unittests
6aa89fc 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Add SHM transport
0edfdcc 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Make arguments const
faf14cd 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Use data_sharing directory
6bc5543 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Use Logs in CLI
65a18ac 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Support Windows & Mac commands
96cf661 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Uncrustify
ab55432 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Protect std::stoi & Add server name
34045d1 
Signed-off-by: cferreiragonz <[email protected]>
@Mario-DL @cferreiragonz
Refs #22106: Fix MacOS build
6ad3416 
Signed-off-by: Mario Dominguez <[email protected]>
@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 5d6e50e to eaf2387 Compare January 8, 2025 13:23
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 8, 2025 13:47
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 8, 2025
@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from eaf2387 to 4871cf4 Compare January 8, 2025 13:56
@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 8, 2025 13:58
@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 4871cf4 to 910729f Compare January 9, 2025 11:14
Mario-DL
Mario-DL requested changes Jan 9, 2025
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job daemonizing, leaving the review.
I am about to test the complete feature under a ROS 2 environment

include/fastdds/rtps/common/PortParameters.hpp Outdated Show resolved Hide resolved
tools/fastdds/discovery/parser.py Show resolved Hide resolved
tools/fastdds/discovery/parser.py Show resolved Hide resolved
tools/fastdds/discovery/parser.py Outdated Show resolved Hide resolved
test/system/tools/fds/CMakeLists.txt Show resolved Hide resolved
tools/fastdds/discovery/fast_daemon/daemon/__init__.py Outdated Show resolved Hide resolved
tools/fds/CliDiscoveryManager.hpp Outdated Show resolved Hide resolved
test/system/tools/fastdds/test_discovery_parser.py Outdated Show resolved Hide resolved
test/system/tools/fds/CliDiscoveryManagerTests.cpp Outdated Show resolved Hide resolved
tools/fds/CliDiscoveryEntrypoint.cpp Outdated Show resolved Hide resolved
@Mario-DL
Copy link
Member

Mario-DL commented Jan 9, 2025

One NIT, I think we should rename the fast_daemon folder name to fastdds_daemon, xmlrpc_daemon, daemon or smth similar

@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from 910729f to e7c0a85 Compare January 9, 2025 13:40
@cferreiragonz
Refs #22106: Add help/examples tests
5a3b95b 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Rearrange methods to simplify windows def
1d8ec2d 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Workaround to solve Mac Tests
9e67dd9 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22106: Minor fixes
f71c502 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22518: Add Fast DDS XML-RPC Daemon
aa5fc74 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22518: Test enum
3bf6cfb 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22518: Cancel fork in cpp tool
72acbde 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22518: Add parser tests
21fd210 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22518: Apply Revision
fa0eed3 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz
Refs #22518: Review - Use stop to shutdown server
6465cd4 
Signed-off-by: cferreiragonz <[email protected]>
@cferreiragonz cferreiragonz force-pushed the feature/auto_ds_daemonized branch from e7c0a85 to 6465cd4 Compare January 10, 2025 09:38
@cferreiragonz
Refs #22518: Apply Revision 2
55a05c7 
Signed-off-by: cferreiragonz <[email protected]>
Mario-DL
Mario-DL approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI on #5551

@cferreiragonz cferreiragonz requested review from richiprosima and removed request for richiprosima January 10, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cferreiragonz @Mario-DL