Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22596] Update submodules when cloning Fast DDS on CI (backport #5558) #5569

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 13, 2025

Description

This adds submodules: true to the checkout actions on all reusable workflows, making them consistent with the windows one, and thus enabling the IDL parser feature tests.

@Mergifyio backport 3.1.x 3.0.x 2.14.x 2.10.x 2.6.x

Contributor Checklist

  • Commit messages follow the project guidelines.

  • N/A: The code follows the style guidelines of this project.

  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally

  • N/A: Any new/modified methods have been properly documented using Doxygen.

  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)

  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.

  • Changes are API compatible.

  • N/A: New feature has been added to the versions.md file (if applicable).

  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.

  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Tests passed in #5559


This is an automatic backport of pull request #5558 done by Mergify.

Signed-off-by: Miguel Company <[email protected]>
(cherry picked from commit 490e80b)
@MiguelCompany MiguelCompany added this to the v3.0.2 milestone Jan 13, 2025
@MiguelCompany MiguelCompany self-requested a review January 13, 2025 13:05
@github-actions github-actions bot added the ci-pending PR which CI is running label Jan 13, 2025
@Mario-DL Mario-DL merged commit ced9509 into 3.0.x Jan 14, 2025
17 checks passed
@Mario-DL Mario-DL deleted the mergify/bp/3.0.x/pr-5558 branch January 14, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants