Upgrade to BMI 2.0 #339
Closed
Upgrade to BMI 2.0 #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was getting
```
RuntimeError: The Poetry configuration is invalid:
- [extras.pipfile_deprecated_finder.2] 'pip-shims<=0.3.4' does not match '^[a-zA-Z-_.0-9]+$'
```
…ns/images in same way
|
Kudos, SonarCloud Quality Gate passed! |
Peter9192
reviewed
Mar 8, 2023
Comment on lines
+27
to
+34
| def start_container( | ||
| work_dir: Union[str, Path], | ||
| image_engine: ImageForContainerEngines, | ||
| input_dirs: Optional[Iterable[str]] = None, | ||
| image_port=55555, | ||
| timeout=None, | ||
| delay=0, | ||
| ) -> Bmi: |
There was a problem hiding this comment.
Having this isolated from the models is great!
Would it be possible to separate the image selection from the actual starting of container? I'd like to be able to start a container by simply passing in an image (assuming that I know which container engine I'm using)
There was a problem hiding this comment.
I added start_apptainer_container() and start_docker_container()
|
Also could you add a changelog entry? |
Merged
Closed
|
Merged as part of #340 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO
[x] Update docsNo docs found using BMI<v2