Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with undefined LED_BUILTIN on Seeed Xiao RP2350 #2704

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Fix issue with undefined LED_BUILTIN on Seeed Xiao RP2350 #2704

merged 4 commits into from
Dec 19, 2024

Conversation

Cincinnatu
Copy link
Contributor

No description provided.

earlephilhower
earlephilhower approved these changes Dec 19, 2024
View reviewed changes
Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This is the problem with defining the pins in a self contained file, vs. using the ../generic/common.h header and just setting any override defines.

@earlephilhower earlephilhower merged commit d5a6888 into earlephilhower:master Dec 19, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@earlephilhower earlephilhower earlephilhower approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Cincinnatu @earlephilhower