Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overclock to 153.6 MHz (instead of 147.6 MHz) for I²S 48 kHz sample rate #2708

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

magy00
Copy link
Contributor

@magy00 magy00 commented Dec 20, 2024

Increasing clk_sys by another 6 MHz would allow for exact 96 kHz and 192 kHz sampling rates (apart from the ±30 ppm of Pico's 12 MHz crystal itself).

@magy00
Copy link
Contributor Author

magy00 commented Dec 20, 2024

Should I2S::setSysClk() return true if clk_sys was (successfully) changed, or should it return false only if any change attempt was unsuccessful (or should it panic() instead)?

tools/makeboards.py Outdated Show resolved Hide resolved
@earlephilhower
Copy link
Owner

Should I2S::setSysClk() return true if clk_sys was (successfully) changed, or should it return false only if any change attempt was unsuccessful (or should it panic() instead)?

In theory if there's a return code I'd not panic and return true if the machine state on output of the function is what I requested (even if it was already good). So your returning of the set_sys_clk is fine.

Copy link
Owner

@earlephilhower earlephilhower left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@earlephilhower earlephilhower merged commit 7961d29 into earlephilhower:master Dec 21, 2024
25 of 26 checks passed
@frohro
Copy link

frohro commented Dec 31, 2024

This is a really nice improvement! Thanks!

@magy00 magy00 deleted the i2s48k branch January 2, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants