Skip to content

Commit

Permalink
Use fail_on_error=False in det_cmake_version().
Browse files Browse the repository at this point in the history
It handles errors itself already by just looking at the output,
no need also do it in run_shell_cmd here. This fixes the test
case for det_cmake_version().
  • Loading branch information
bartoldeman committed Dec 7, 2023
1 parent c5b7f46 commit d5e54a9
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion easybuild/easyblocks/generic/cmakemake.py
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ def det_cmake_version():
regex = re.compile(r"^[cC][mM]ake version (?P<version>[0-9]\.[0-9a-zA-Z.-]+)$", re.M)

cmd = "cmake --version"
cmd_res = run_shell_cmd(cmd, hidden=True)
cmd_res = run_shell_cmd(cmd, hidden=True, fail_on_error=False)
out = cmd_res.output
res = regex.search(out)
if res:
Expand Down

0 comments on commit d5e54a9

Please sign in to comment.