Don't use setup.py if Gurobi v >= 11.0.0 #3160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boegel
reviewed
Feb 13, 2024
| run_cmd('python setup.py install --prefix=%s' % self.installdir) | ||
| else: | ||
| run_cmd( | ||
| 'python -m pip install --find-links=%s --no-index --no-deps --ignore-installed \ |
There was a problem hiding this comment.
Although this will work, the (big) downside of this approach is that this will make pip download the gurobipy wheel from PyPI, rather than letting EasyBuild download (and cache it).
I took a different approach in #3225 + easybuilders/easybuild-easyconfigs#19838, by simply disabling the use of setup.py, and installing gurobipy as an extension to Gurobi, which leaves EasyBuild in control of the downloading from PyPI...
There was a problem hiding this comment.
I see, that is indeed a much better solution. Feel free and close this and PR easybuilders/easybuild-easyconfigs#19838, or just ping me and I'll add a note and close them 👍
|
close in favour of #3225 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(created using
eb --new-pr)Needed by easybuilders/easybuild-easyconfigs#19794.
Addresses changes to the Gurobi installation procedure from v11.0.0 and onward, that does not allow for installation via
setup.py. In fact, from v11.0.0setup.pysimply raises an exception and terminates the installation ofgurobipyimmediately.I have added a check for the version number to handle such cases, which now install
gurobipyviapip install. I have tested this approach on the HPC I have access to and it seems to work well.