Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_cmd with run_shell_cmd in custom easyblock for TensorFlow (tensorflow.py) #3165

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 7, 2024

(created using eb --new-pr)

@branfosj
Copy link
Member Author

branfosj commented Feb 7, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.13.0-foss-2023a.eb
  • SUCCESS TensorFlow-2.4.1-foss-2020b.eb

Build succeeded for 2 out of 2 (2 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/7d3785bf6108f9f85e48fcd45ee59759 for a full test report.

@boegel
Copy link
Member

boegel commented Feb 7, 2024

@boegelbot please test @ jsc-zen3
CORE_CNT=16
EB_BRANCH="5.0.x"
EB_ARGS="TensorFlow-2.13.0-foss-2022b.eb --installpath /tmp/$USER/pr3165"

@boegelbot
Copy link

@boegel: Request for testing this PR well received on jsczen3l1.int.jsc-zen3.fz-juelich.de

PR test command 'if [[ "5.0.x" != 'develop' ]]; then EB_BRANCH="5.0.x" ./easybuild_develop.sh 2> /dev/null 1>&2; EB_PREFIX=/home/boegelbot/easybuild/"5.0.x" source init_env_easybuild_develop.sh; fi; EB_PR=3165 EB_ARGS="TensorFlow-2.13.0-foss-2022b.eb --installpath /tmp/$USER/pr3165" EB_REPO=easybuild-easyblocks EB_BRANCH="5.0.x" /opt/software/slurm/bin/sbatch --job-name test_PR_3165 --ntasks="16" ~/boegelbot/eb_from_pr_upload_jsc-zen3.sh' executed!

  • exit code: 0
  • output:
Submitted batch job 3573

Test results coming soon (I hope)...

- notification for comment with ID 1932332002 processed

Message to humans: this is just bookkeeping information for me,
it is of no use to you (unless you think I have a bug, which I don't).

@branfosj
Copy link
Member Author

branfosj commented Feb 7, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.11.0-foss-2022a-CUDA-11.7.0.eb
  • SUCCESS h5py-3.1.0-fosscuda-2020b.eb
  • SUCCESS TensorFlow-2.5.0-fosscuda-2020b.eb

Build succeeded for 3 out of 3 (2 easyconfigs in total)
bear-pg0208u15a - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), 1 x NVIDIA NVIDIA A100-SXM4-40GB, 520.61.05, Python 3.6.8
See https://gist.github.com/branfosj/51075038a946d1c5b0cad2810dc650d3 for a full test report.

@boegelbot
Copy link

Test report by @boegelbot

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.13.0-foss-2022b.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
jsczen3c1.int.jsc-zen3.fz-juelich.de - Linux Rocky Linux 9.3, x86_64, AMD EPYC-Milan Processor (zen3), Python 3.9.18
See https://gist.github.com/boegelbot/7f70602349d6d8f832844a6cfc60f32e for a full test report.

easybuild/easyblocks/t/tensorflow.py Outdated Show resolved Hide resolved
@branfosj branfosj requested a review from boegel February 7, 2024 18:36
Copy link
Member

@boegel boegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@boegel
Copy link
Member

boegel commented Feb 7, 2024

Test report by @boegel

Overview of tested easyconfigs (in order)

  • SUCCESS TensorFlow-2.11.0-foss-2022a-CUDA-11.7.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
node3306.joltik.os - Linux RHEL 8.8, x86_64, Intel(R) Xeon(R) Gold 6242 CPU @ 2.80GHz, 1 x NVIDIA Tesla V100-SXM2-32GB, 535.154.05, Python 3.6.8
See https://gist.github.com/boegel/e30343b04c8bd1833fcc865c94acb642 for a full test report.

@boegel boegel merged commit e565dc5 into easybuilders:5.0.x Feb 7, 2024
17 checks passed
@branfosj branfosj deleted the 20240207121631_new_pr_tensorflow branch February 7, 2024 22:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

3 participants