Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace run_cmd with run_shell_cmd in custom easyblock for TINKER (tinker.py) #3180

Merged

Conversation

branfosj
Copy link
Member

@branfosj branfosj commented Feb 7, 2024

(created using eb --new-pr)

@branfosj branfosj added this to the 5.0 milestone Feb 7, 2024
@branfosj branfosj added change EasyBuild-5.0 EasyBuild 5.0 labels Feb 7, 2024
@branfosj
Copy link
Member Author

branfosj commented Feb 7, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/branfosj/efd536c279f8d0f015f3f1d5a2e3fc8f for a full test report.

edit failure due to source not being available

@branfosj
Copy link
Member Author

branfosj commented Feb 7, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS TINKER-8.8.3-foss-2020a.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0211u08b.bear.cluster - Linux RHEL 8.6, x86_64, Intel(R) Xeon(R) Gold 6248 CPU @ 2.50GHz (cascadelake), Python 3.6.8
See https://gist.github.com/branfosj/49f205aebc32eb87be8788fce26316d1 for a full test report.

Copy link
Contributor

@bartoldeman bartoldeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bartoldeman bartoldeman merged commit 63fc353 into easybuilders:5.0.x Feb 8, 2024
17 checks passed
@branfosj branfosj deleted the 20240207171538_new_pr_tinker branch February 8, 2024 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants