Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of deprecated extract_errors_from_log in configuremake #3540

Merged

Conversation

branfosj
Copy link
Member

(created using eb --new-pr)

@branfosj branfosj added this to the 5.0 milestone Dec 20, 2024
@branfosj
Copy link
Member Author

branfosj commented Dec 20, 2024

Test report by @branfosj

Overview of tested easyconfigs (in order)

Build succeeded for 0 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/a525c3e10624e6a0420c268b2395049a for a full test report.

edit: This was using a deliberatly broken FriBidi-1.0.12-GCCcore-12.3.0.eb where I'd added configopts = '--disable-docs --with-penguins' and this fails, as expected, with

FAILED: Installation ended unsuccessfully: Found unrecognized configure options: configure: WARNING: unrecognized options: --disable-docs, --with-penguins

@branfosj
Copy link
Member Author

Test report by @branfosj

Overview of tested easyconfigs (in order)

  • SUCCESS FriBidi-1.0.12-GCCcore-12.3.0.eb

Build succeeded for 1 out of 1 (1 easyconfigs in total)
bear-pg0105u03a - Linux RHEL 8.10, x86_64, Intel(R) Xeon(R) Platinum 8360Y CPU @ 2.40GHz (icelake), Python 3.6.8
See https://gist.github.com/branfosj/c16580572a07c191af5f8d4a64327f34 for a full test report.

Copy link
Contributor

@lexming lexming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lexming
Copy link
Contributor

lexming commented Dec 21, 2024

Merging, thanks @branfosj

@lexming lexming merged commit f293fb5 into easybuilders:5.0.x Dec 21, 2024
19 checks passed
@branfosj branfosj deleted the 20241220130412_new_pr_configuremake branch December 21, 2024 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants