Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The name suggest running a command and copy files. However the commands need to be specified as a regex-map list which might be executed for every source instead of once. Often a workflow might be just
./custom_configure && ./custom_build.sh
which is not easy to map to this.Instead allow non-tuples which are considered as commands to be run. When mixing tuples and non-tuples the plain commands are run last.
This was always a concern of mine that a workflow consisting of running only a command that involves some custom install procedure was less obvious than it might be. It came up recently where an EC uses
MakeCp
requiringparallel = False
as it replaces themake
cmd by a single command. In that case it is./configure --options
and./coconut
which isn't easily applicable usingCmdCp
With this change it can be:
I'd say this is easier to read and understand than:
Also error reporting would be more focused, i.e. either "./configure failed" or "./coconut failed"
I can port a couple easyconfigs to the new syntax in a PR to the easyconfig repo for test reports and usage examples.