Skip to content

Commit

Permalink
Merge branch 'main' into strengejacke/issue439
Browse files Browse the repository at this point in the history
  • Loading branch information
strengejacke authored Jun 27, 2024
2 parents 5b01c6c + 1580a22 commit d7c4ee4
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 3 deletions.
5 changes: 5 additions & 0 deletions NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,11 @@ Minor changes
* `report` now supports reporting of BayesFactor objects with variables of class `BFBayesFactor`.
* `report_sample()` now suggests valid column names for misspelled columns in the `select`, `by`, `weights` and `exclude` arguments.

Bug fixes

* Fixed issues with incorrectly passing additional arguments to downstream
functions in `report()` for `htest` objects.

# report 0.5.8

New features
Expand Down
2 changes: 1 addition & 1 deletion R/report_htest_chi2.R
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
estimate <- names(table)[1]
rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)

args <- list(table, rules = rules, dot_args)
args <- c(list(table, rules = rules), dot_args)
interpretation <- do.call(effectsize::interpret, args)$Interpretation
rules <- .text_effectsize(attr(attr(interpretation, "rules"), "rule_name"))
} else {
Expand Down
2 changes: 1 addition & 1 deletion R/report_htest_fisher.R
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
estimate <- names(table)[1]
rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)

args <- list(table, rules = rules, dot_args)
args <- c(list(table, rules = rules), dot_args)
interpretation <- do.call(effectsize::interpret, args)$Interpretation
rules <- .text_effectsize(attr(attr(interpretation, "rules"), "rule_name"))

Expand Down
2 changes: 1 addition & 1 deletion R/report_htest_ttest.R
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
estimate <- names(table)[1]
rules <- ifelse(is.null(dot_args$rules), rules, dot_args$rules)

my_args <- list(table, rules = rules, dot_args)
my_args <- c(list(table, rules = rules), dot_args)
interpretation <- do.call(effectsize::interpret, my_args)$Interpretation
rules <- .text_effectsize(attr(attr(interpretation, "rules"), "rule_name"))

Expand Down

0 comments on commit d7c4ee4

Please sign in to comment.