Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Valid QVM startup under GCC UBSan reports an unaligned
int32_tload inVM_LoadInstructions. Copy the four operand bytes with the existingCopyLittleLonghelper into an int32_t temporary, then retain the existing assignment and instruction advance.All interpreter and architecture compiler callers use this shared function. No opcode, instruction layout, arithmetic or JIT behavior changes.
Reproduced on upstream f694bbb with a dedicated GCC UBSan build:
/tmp/zip-only.suppcontains onlyalignment:unzlocal_GetCurrentFileInfoInternal, for the independent ZIP issue in #428. Use a fresh home and installed valid content. Before: exit 1 at vm.c:1181. After: clean startup and exit 0. No game content is included.The fork's existing GCC UBSan bot smoke passes both Quake 3 and OpenArena map goldens with no alignment suppressions after this fix. GCC x86_64 production symbols pass; all 26 function sections are byte-identical. The assembly-text gate reports only the compiler-generated switch-table name changing from CSWTCH.89 to CSWTCH.90, with no instruction or table-data changes.
Tracked in msetaro#31.