Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unix and Windows Sys_LoadLibrary print FS_AllowedExtension's output on a true return, but the function only populated that output on false returns. Initialize the supplied output for every filename, using an empty string when there is no dot. Preserve classification, casing, and the special
.so.Nsuffix.This fixes the shared output contract for both platform callers. Existing callers that inspect the output only on false returns keep the same strings.
Regression:
Before: the output assertion fails for an extensionless name. After: empty/extensionless/trailing-dot, ordinary extension, versioned .so and allowed/disallowed pk3 cases pass. The separate pointer-arithmetic fix in #425 is unchanged by this patch.
The fork includes these assertions in its existing unit driver. Sanitizer/pointer modes, original unit/collision/smoke/frame goldens pass. Production symbol gate passes; machine-code bytes change only in FS_AllowedExtension among 99 function sections, for the added output initialization. The text diff also renames a compiler switch-table label in FS_Seek; its bytes are unchanged. Tracked in msetaro#31.